bugTechne - Bugs: bug #34320, Does not build with plplot 5.9.8...

 
 

bug #34320: Does not build with plplot 5.9.8 due API changes

Submitted by:  speps <speps>
Submitted on:  Sat 17 Sep 2011 02:59:39 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 09 Nov 2011 11:01:07 AM UTC, comment #3:

I've tested this myself after installing 5.9.8 during a system upgrade and the patch seems to be working fine. I'm closing this.

Dimitris Papavasiliou <dpapavas>
Project Administrator
Tue 20 Sep 2011 07:51:52 PM UTC, comment #2:

I've added an autoconf test which tries to find out how many parameters plarc expects. Could you check out Techne from cvs and try to compile it with plPlot 5.9.8 to see if the issue has been fixed? You can find the relevant instructions for anonymous checkout here in the project page. Once you have the sources enter the toplevel dir and run the command:

autoreconf -i

You need to have the autotools enabled for this to work. Then it's the usual ./configure, make, etc.

When configuring make sure you get the message:

checking whether the plarc hack is needed... yes

Dimitris Papavasiliou <dpapavas>
Project Administrator
Mon 19 Sep 2011 11:49:17 AM UTC, comment #1:

Hi,

thanks for the comprehensive report! The problem is that if I modify the call as you suggest it will then break on all versions prior to 5.9.8. As far as I can see there's no way to get the version at compile time. No macro or anything of the like. There's only plgver which is fairly useless. I'll look into it some more...

Dimitris Papavasiliou <dpapavas>
Project Administrator
Sat 17 Sep 2011 02:59:39 PM UTC, original submission:

From README.release included in plplot 5.9.8 tarball (released on 1 August):
(5.9.8) The plarc API has changed in release 5.9.8. The plarc API now
has a rotation parameter which will eventually allow for rotated arcs.
PLplot does not currently support rotated arcs, but the plarc function
signature has been modified to avoid changing the API when this
functionality is added.

in src/plotting.c line 459:

plarc (x, y, r, rho, theta, phi, 0);

miss the last parameter and cause build fail.

New definition is:

PLDLLIMPEXP void
c_plarc( PLFLT x, PLFLT y, PLFLT a, PLFLT b, PLFLT angle1, PLFLT angle2,
PLFLT rotate, PLBOOL fill );

So changing in:

plarc (x, y, r, rho, theta, phi, 0, 0);

should be enough.

speps <speps>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by dpapavas (Posted a comment)
  • -unavailable- added by speps (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 09 Nov 2011 11:01:19 AM UTCdpapavasOpen/ClosedOpen=>Closed
    Wed 09 Nov 2011 11:01:07 AM UTCdpapavasStatusNone=>Fixed

    Back to the top


    Powered by Savane 3.1-cleanup1