buglwIP - A Lightweight TCP/IP stack - Bugs: bug #34581, missing parentheses in udplite...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #34581: missing parentheses in udplite sockets code

Submitted by:  Amir Shalem <amirshalem>
Submitted on:  Mon 17 Oct 2011 11:32:11 PM UTC  
 
Category: sockets/netconnSeverity: 3 - Normal
Item Group: Change RequestStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: CVS Head

Tue 18 Oct 2011 09:12:39 AM UTC, comment #1:

Fixed, thanks for reporting.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Mon 17 Oct 2011 11:32:11 PM UTC, original submission:

gcc recommends suggest parentheses around ‘&&’ within ‘||’:

- if (((int)optval != 0) && (((int)optval < 8)) || ((int)optval > 0xffff)) {
+ if (((int)optval != 0) && ((((int)optval < 8)) || ((int)optval > 0xffff))) {

add patch to fix those bugs

thanks,
amir shalem

Amir Shalem <amirshalem>

 

Attached Files
file #24165:  missing-parentheses.patch added by amirshalem (1KiB - application/octet-stream - patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by amirshalem (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 18 Oct 2011 09:12:39 AM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed
      Planned Release=>1.4.1
    Mon 17 Oct 2011 11:33:05 PM UTCamirshalemAttached File-=>Added missing-parentheses.patch, #24165

    Back to the top


    Powered by Savane 3.1-cleanup1