buglwIP - A Lightweight TCP/IP stack - Bugs: bug #34587, TCP_BUILD_MSS_OPTION doesn't...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #34587: TCP_BUILD_MSS_OPTION doesn't consider netif->mtu, causes slow network

Submitted by:  Amir Shalem <amirshalem>
Submitted on:  Tue 18 Oct 2011 03:05:31 PM UTC  
 
Category: TCPSeverity: 3 - Normal
Item Group: Faulty BehaviourStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: CVS Head

Tue 18 Oct 2011 06:20:31 PM UTC, comment #1:

Fixed, thanks for reporting.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Tue 18 Oct 2011 03:05:31 PM UTC, original submission:

TCP_BUILD_MSS_OPTION() only uses TCP_MSS value,
then if netif->mtu is smaller than TCP_MSS then there will be a lot of IP fragmentation when packets will be going out = very slow network.

TCP_BUILD_MSS_OPTION should consider the route to dest_addr, and ask the netif his mtu, and lower the tcp mss if required.

Thanks,
Amir Shalem

Amir Shalem <amirshalem>

 

Attached Files
file #24168:  advmss-correctly.patch added by amirshalem (2KiB - application/octet-stream - advmss patch )

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by amirshalem (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 18 Oct 2011 06:20:31 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed
      Planned Release=>1.4.1
    Tue 18 Oct 2011 05:04:43 PM UTCamirshalemAttached File-=>Added advmss-correctly.patch, #24168

    Back to the top


    Powered by Savane 3.1-cleanup1