buglwIP - A Lightweight TCP/IP stack - Bugs: bug #34587, TCP_BUILD_MSS_OPTION doesn't...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #34587: TCP_BUILD_MSS_OPTION doesn't consider netif->mtu, causes slow network

Submitter:  Amir Shalem <amirshalem>
Submitted:  Tue 18 Oct 2011 03:05:31 PM UTC
   
 
Category:  TCP Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  CVS Head

Tue 18 Oct 2011 06:20:31 PM UTC, comment #1: 

Fixed, thanks for reporting.

Simon Goldschmidt <goldsimon>
Group administrator
Tue 18 Oct 2011 03:05:31 PM UTC, original submission:  

TCP_BUILD_MSS_OPTION() only uses TCP_MSS value,
then if netif->mtu is smaller than TCP_MSS then there will be a lot of IP fragmentation when packets will be going out = very slow network.

TCP_BUILD_MSS_OPTION should consider the route to dest_addr, and ask the netif his mtu, and lower the tcp mss if required.

Thanks,
Amir Shalem

Amir Shalem <amirshalem>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #24168:  advmss-correctly.patch added by amirshalem (2KiB - application/octet-stream - advmss patch )

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by amirshalem (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-10-18 goldsimon StatusNone Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
        Planned Release 1.4.1
    2011-10-18 amirshalem Attached File- Added advmss-correctly.patch, #24168

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code