buglwIP - A Lightweight TCP/IP stack - Bugs: bug #34681, Limit ARP queue length by...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #34681: Limit ARP queue length by ARP_QUEUE_LEN (=3)

Submitted by:  Amir Shalem <amirshalem>
Submitted on:  Sat 29 Oct 2011 08:37:52 AM UTC  
 
Category: ARPSeverity: 3 - Normal
Item Group: Change RequestStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: CVS Head

Sat 22 Feb 2014 08:39:47 PM UTC, comment #4:

And also finally done, thanks for the patch.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 10 Nov 2011 04:34:22 PM UTC, comment #3:

OK, that seems fair enough then, I'm happy to replicate what others do in this circumstance.

Kieran Mansley <kieranm>
Project Administrator
Tue 08 Nov 2011 06:01:11 AM UTC, comment #2:

That's may be true, but the ARP layer is not IP.

After black box testing Windows & Linux, it seems both are dropping old packets in favor of new packets.
Which means that the newest TCP SYN packet will be sent, and not the oldest.

Amir Shalem <amirshalem>
Tue 01 Nov 2011 12:52:43 PM UTC, comment #1:

This seems like a reasonable feature.

I'm just wondering if dropping old packets in favour of new ones is the right approach. At most points in a stack new packets are dropped in favour of old ones.

Kieran Mansley <kieranm>
Project Administrator
Sat 29 Oct 2011 08:37:52 AM UTC, original submission:

I propose to limit the ARP queue length, by ARP_QUEUE_LEN (defaults to 3).

This will make sure that if two IPs are unresolved, then the first one them won't be able to "steal" all the MEMP_ARP_QUEUE objects, by limiting both queues to ARP_QUEUE_LEN packets awaiting in each queue.

From what I understand & tested, this will shouldn't hurt any higher level (UDP, TCP, ICMP, applications, ...)

Patch included.

Amir Shalem

Amir Shalem <amirshalem>

 

Attached Files
file #24237:  limit_arp_queue_length.patch added by amirshalem (2KiB - application/octet-stream - ARP_QUEUE_LEN patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by kieranm (Posted a comment)
  • -unavailable- added by amirshalem (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 22 Feb 2014 08:39:47 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed
    Tue 01 Nov 2011 01:04:06 PM UTCkieranmPlanned Release=>1.5.0
    Sat 29 Oct 2011 08:37:52 AM UTCamirshalemAttached File-=>Added limit_arp_queue_length.patch, #24237

    Back to the top


    Powered by Savane 3.1-cleanup1