bugText Extractor TXR - Bugs: bug #34691, Recent refactoring may have...

 
 

bug #34691: Recent refactoring may have broken memory performance.

Submitted by:  Kaz Kylheku <kkylheku>
Submitted on:  Sun 30 Oct 2011 05:57:07 AM UTC  
 
Category: NoneSeverity: 5 - Blocker
Item Group: CorrectnessStatus: Fixed
Privacy: PublicAssigned to: Kaz Kylheku <kkylheku>
Originator Name: Open/Closed: Closed
Component Version: NoneOperating System: None
Fixed Release: NonePlanned Release: None
Architecture: AllABI: All

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 30 Oct 2011 06:44:39 AM UTC, comment #1:

Addressed in

http://www.kylheku.com/cgit/txr/commit/?id=984dbecdbf702c5c3b49a82c6d401f0eb15d2731

Kaz Kylheku <kkylheku>
Project AdministratorIn charge of this item.
Sun 30 Oct 2011 05:57:07 AM UTC, original submission:

It looks like the protocol between match_files and the factored out directive handlers breaks some of the good memory performance in TXR.

The problem is that the functions like v_skip receive a copy of the match_file_ctx structure. This means that while they are working, the calling function hangs on to the originals structure which maintains a c.data pointer to the original data.

Thus even if the invoked directive advances through the data such that backtracking will not happen any more, the data between the starting position and the new position will not be garbage collected until that directive returns.

The old behavior was that progressive garbage collection occured in the searching directives like skip and collect, because they were integrated into match_files and updated the local "data" variable directly.

Kaz Kylheku <kkylheku>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by kkylheku (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 30 Oct 2011 06:44:39 AM UTCkkylhekuStatusNeed Info=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1