bugpyFormex - Bugs: bug #35370, Functions getEdges and...

 
 

bug #35370: Functions getEdges and getElemEdges mixed up in Trisurface.py

Submitted by:  Sofie Van Cauter <svcauter>
Submitted on:  Wed 25 Jan 2012 04:37:14 PM UTC  
 
Category: PluginsSeverity: 3 - Normal
Item Group: Functionality errorStatus: In Progress
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 23 Mar 2012 10:34:11 AM UTC, comment #1:

If the self.edges set by getElemEdges is the same as that set by getEdges, there should not be a problem.

If it is different, then we should probably just use a temporary variable in getElemEdges, as nothing is done with the second return value.

I am inclined to do the second.

Benedict Verhegghe <bverheg>
Project Administrator
Wed 25 Jan 2012 04:37:14 PM UTC, original submission:

There seems to be a problem in the TriSurface._compute_data function, which contains the following code:
edg = self.coords[self.getEdges()]
edglen = length(edg[:,1]-edg[:,0])
facedg = edglen[self.getElemEdges()]
The function getEdges sets and returns self.edges, but getElemEdges() resets self.edges and as a result, facedg is not correct. Maybe it would be more straightforward if getElemEdges would also return the new self.edges?

Similar code is found in TriSurface.intersectionWithPlane:
edg = S.getEdges()
fac = S.getElemEdges()

Sofie Van Cauter <svcauter>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bverheg (Posted a comment)
  • -unavailable- added by svcauter (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 28 Mar 2012 01:47:17 PM UTCsvcauterOpen/ClosedOpen=>Closed
    Fri 23 Mar 2012 10:34:11 AM UTCbverhegItem GroupNone=>Functionality error
      StatusNone=>In Progress

    Back to the top


    Powered by Savane 3.1-cleanup1