bugAVR Downloader/UploaDEr - Bugs: bug #35406, configure.ac: check for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #35406: configure.ac: check for yylex_destroy not sufficient

Submitted by:  Joerg Wunsch <joerg_wunsch>
Submitted on:  Mon 30 Jan 2012 04:25:53 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: FixedPrivacy: Public
Assigned to: Rene Liebscher <rliebscher>Originator Name: Jörg Wunsch
Open/Closed: ClosedRelease: None
Programmer hardware: Device type: 

Mon 30 Jan 2012 08:48:22 PM UTC, comment #5:

Fixed in svn revision 1049

Rene Liebscher <rliebscher>
Project MemberIn charge of this item.
Mon 30 Jan 2012 08:24:35 PM UTC, comment #4:

Works great!

Old Linux:

checking whether yylex_destroy is generated by flex... version 2.5.4 => no

My FreeBSD at home:

checking whether yylex_destroy is generated by flex... version 2.5.35 => yes

Danke schön!

Joerg Wunsch <joerg_wunsch>
Project Administrator
Mon 30 Jan 2012 08:06:38 PM UTC, comment #3:

Ok, then try the attached patch. It checks the version number of flex.

(file #24925)

Rene Liebscher <rliebscher>
Project MemberIn charge of this item.
Mon 30 Jan 2012 05:00:39 PM UTC, comment #2:

Yeah, that's a pretty old system. But it's a production Linux
system, so you can assume other similarly old systems can be
found in the wild.

No idea how old the source code has been; the binary dates to
2005.

Well, we could try to test-compile something, but it's also
possible to just check the output of flex -V. The flex
documentation says yylex_destroy() has been supported as of
flex version 2.5.9:

http://flex.sourceforge.net/manual/The-Default-Memory-Management.html

Joerg Wunsch <joerg_wunsch>
Project Administrator
Mon 30 Jan 2012 04:46:03 PM UTC, comment #1:

yylex_destroy will be generated in the lexer.c file.

At least flex 2.5.9 will generate it, current flex version is 2.5.35 (February 26, 2008). So 2.5.4 is rather old? (2.5.4a: June 27, 1997).

To support the old version we need to parse the version string of flex or do create some test lexer and check if it links.

Any proposals how to do this?

Rene Liebscher <rliebscher>
Project MemberIn charge of this item.
Mon 30 Jan 2012 04:25:53 PM UTC, original submission:

Adding -lfl doesn't solve the issue either. Seems the configure.ac
check needs to be made more sophisticated.

Joerg Wunsch <joerg_wunsch>
Project Administrator

 

Attached Files
file #24925:  configure-flex.patch added by rliebscher (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rliebscher (Posted a comment)
  • -unavailable- added by joerg_wunsch (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 30 Jan 2012 08:48:22 PM UTCrliebscherStatusNone=>Fixed
      Assigned toNone=>rliebscher
      Open/ClosedOpen=>Closed
    Mon 30 Jan 2012 08:06:38 PM UTCrliebscherAttached File-=>Added configure-flex.patch, #24925

    Back to the top


    Powered by Savane 3.1-cleanup1