bugThe FreeType Project - Bugs: bug #35598, Out-of-bounds read in _bdf_is_atom...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #35598: Out-of-bounds read in _bdf_is_atom / _bdf_parse_properties, bdf parsing

Submitter:  Mateusz Jurczyk <j00ru>
Submitted:  Thu 23 Feb 2012 12:18:59 PM UTC
 
Severity:  3 - Normal Item Group:  Crash
Status:  Fixed Privacy:  Public
Assigned to:  wl Open/Closed:  Closed
Planned Release:  2.4.9

Sun 26 Feb 2012 07:15:37 AM UTC, comment #1: 

Fixed in git, thanks.

Werner LEMBERG <wl>
Project Administrator
Thu 23 Feb 2012 12:18:59 PM UTC, original submission:  

Crash tested with ftbench, compiled under Ubuntu amd64 with AddressSanitizer (http://code.google.com/p/address-sanitizer/).

Log from ASAN build:

=================================================================
==28267== ERROR: AddressSanitizer heap-buffer-overflow on address 0x7fb2e7756480 at pc 0x572af4 bp 0x7fff18f2a160 sp 0x7fff18f2a158
READ of size 1 at 0x7fb2e7756480 thread T0
  #0 0x572af4 _bdf_is_atom
  #1 0x56df8c _bdf_parse_properties
  #2 0x56a876 _bdf_readstream
  #3 0x568a19 bdf_load_font
  #4 0x565aad BDF_Face_Init
  #5 0x4913e0 open_face
  #6 0x4909a3 FT_Open_Face
  #7 0x48fd06 FT_New_Face
  #8 0x487557 get_face
  #9 0x487cb1 main
  #10 0x7fb2e83aad5d __libc_start_main
0x7fb2e7756480 is located 0 bytes to the right of 1024-byte region [0x7fb2e7756080,0x7fb2e7756480)
allocated by thread T0 here:
  #0 0x5c3222 malloc
  #1 0x4a0434 ft_mem_qalloc
  #2 0x48b3cf ft_mem_alloc
  #3 0x4a3012 ft_mem_qrealloc
  #4 0x48bccd ft_mem_realloc
  #5 0x56a6cd _bdf_readstream
  #6 0x568a19 bdf_load_font
  #7 0x565aad BDF_Face_Init
  #8 0x4913e0 open_face
  #9 0x4909a3 FT_Open_Face
  #10 0x48fd06 FT_New_Face
  #11 0x487557 get_face
  #12 0x487cb1 main
  #13 0x7fb2e83aad5d __libc_start_main
==28267== ABORTING
Stats: 0M malloced (0M for red zones) by 818 calls
Stats: 0M realloced by 3 calls
Stats: 0M freed by 31 calls
Stats: 0M really freed by 0 calls
Stats: 32M (8196 full pages) mmaped in 8 calls
  mmaps   by size class: 8:16383; 9:8191; 10:4095; 11:2047; 12:1024; 13:512; 15:128; 16:64;
  mallocs by size class: 8:778; 9:20; 10:7; 11:6; 12:3; 13:1; 15:2; 16:1;
  frees   by size class: 8:18; 9:3; 10:6; 11:2; 12:1; 13:1;
  rfrees  by size class:
Stats: malloc large: 0 small slow: 9
Shadow byte and word:
  0x1ff65ceeac90: fa
  0x1ff65ceeac90: fa fa fa fa fa fa fa fa
More shadow bytes:
  0x1ff65ceeac70: 00 00 00 00 00 00 00 00
  0x1ff65ceeac78: 00 00 00 00 00 00 00 00
  0x1ff65ceeac80: 00 00 00 00 00 00 00 00
  0x1ff65ceeac88: 00 00 00 00 00 00 00 00
=>0x1ff65ceeac90: fa fa fa fa fa fa fa fa
  0x1ff65ceeac98: fa fa fa fa fa fa fa fa
  0x1ff65ceeaca0: fa fa fa fa fa fa fa fa
  0x1ff65ceeaca8: fa fa fa fa fa fa fa fa
  0x1ff65ceeacb0: fa fa fa fa fa fa fa fa

Log from Valgrind:

==28223== Memcheck, a memory error detector
==28223== Copyright (C) 2002-2011, and GNU GPL'd, by Julian Seward et al.
==28223== Using Valgrind-3.8.0.SVN and LibVEX; rerun with -h for copyright info
==28223== Command: ./a.out tmp/freetype/10x20gmb.bdf.asan.24.6
==28223==
==28223== Invalid read of size 1
==28223==    at 0x433E40: _bdf_parse_properties (freetype2/freetype-2.4.8/src/bdf/bdflib.c:1245)
==28223==    by 0x433000: BDF_Face_Init (freetype2/freetype-2.4.8/src/bdf/bdflib.c:722)
==28223==    by 0x4089B7: open_face (freetype2/freetype-2.4.8/src/base/ftobjs.c:1149)
==28223==    by 0x40B362: FT_Open_Face (freetype2/freetype-2.4.8/src/base/ftobjs.c:2076)
==28223==    by 0x40C58A: FT_New_Face (freetype2/freetype-2.4.8/src/base/ftobjs.c:1211)
==28223==    by 0x40235C: get_face (freetype2/ft2demos-2.4.8/src/ftbench.c:624)
==28223==    by 0x402660: main (freetype2/ft2demos-2.4.8/src/ftbench.c:752)
==28223==  Address 0x53dc780 is 0 bytes after a block of size 1,024 alloc'd
==28223==    at 0x4C2A4D6: malloc (coregrind/m_replacemalloc/vg_replace_malloc.c:263)
==28223==    by 0x406CBF: ft_mem_qalloc (freetype2/freetype-2.4.8/src/base/ftutil.c:76)
==28223==    by 0x4082D2: ft_mem_alloc (freetype2/freetype-2.4.8/src/base/ftutil.c:55)
==28223==    by 0x408404: ft_mem_qrealloc (freetype2/freetype-2.4.8/src/base/ftutil.c:145)
==28223==    by 0x408CCA: ft_mem_realloc (freetype2/freetype-2.4.8/src/base/ftutil.c:101)
==28223==    by 0x4326A1: BDF_Face_Init (freetype2/freetype-2.4.8/src/bdf/bdflib.c:634)
==28223==    by 0x4089B7: open_face (freetype2/freetype-2.4.8/src/base/ftobjs.c:1149)
==28223==    by 0x40B362: FT_Open_Face (freetype2/freetype-2.4.8/src/base/ftobjs.c:2076)
==28223==    by 0x40C58A: FT_New_Face (freetype2/freetype-2.4.8/src/base/ftobjs.c:1211)
==28223==    by 0x40235C: get_face (freetype2/ft2demos-2.4.8/src/ftbench.c:624)
==28223==    by 0x402660: main (freetype2/ft2demos-2.4.8/src/ftbench.c:752)
==28223==
==28223== Invalid read of size 1
==28223==    at 0x43396B: _bdf_add_property (freetype2/freetype-2.4.8/src/bdf/bdflib.c:1362)
==28223==    by 0x433C06: _bdf_parse_properties (freetype2/freetype-2.4.8/src/bdf/bdflib.c:1964)
==28223==    by 0x433000: BDF_Face_Init (freetype2/freetype-2.4.8/src/bdf/bdflib.c:722)
==28223==    by 0x4089B7: open_face (freetype2/freetype-2.4.8/src/base/ftobjs.c:1149)
==28223==    by 0x40B362: FT_Open_Face (freetype2/freetype-2.4.8/src/base/ftobjs.c:2076)
==28223==    by 0x40C58A: FT_New_Face (freetype2/freetype-2.4.8/src/base/ftobjs.c:1211)
==28223==    by 0x40235C: get_face (freetype2/ft2demos-2.4.8/src/ftbench.c:624)
==28223==    by 0x402660: main (freetype2/ft2demos-2.4.8/src/ftbench.c:752)
==28223==  Address 0x53dc780 is 0 bytes after a block of size 1,024 alloc'd
==28223==    at 0x4C2A4D6: malloc (coregrind/m_replacemalloc/vg_replace_malloc.c:263)
==28223==    by 0x406CBF: ft_mem_qalloc (freetype2/freetype-2.4.8/src/base/ftutil.c:76)
==28223==    by 0x4082D2: ft_mem_alloc (freetype2/freetype-2.4.8/src/base/ftutil.c:55)
==28223==    by 0x408404: ft_mem_qrealloc (freetype2/freetype-2.4.8/src/base/ftutil.c:145)
==28223==    by 0x408CCA: ft_mem_realloc (freetype2/freetype-2.4.8/src/base/ftutil.c:101)
==28223==    by 0x4326A1: BDF_Face_Init (freetype2/freetype-2.4.8/src/bdf/bdflib.c:634)
==28223==    by 0x4089B7: open_face (freetype2/freetype-2.4.8/src/base/ftobjs.c:1149)
==28223==    by 0x40B362: FT_Open_Face (freetype2/freetype-2.4.8/src/base/ftobjs.c:2076)
==28223==    by 0x40C58A: FT_New_Face (freetype2/freetype-2.4.8/src/base/ftobjs.c:1211)
==28223==    by 0x40235C: get_face (freetype2/ft2demos-2.4.8/src/ftbench.c:624)
==28223==    by 0x402660: main (freetype2/ft2demos-2.4.8/src/ftbench.c:752)
==28223==
couldn't load font resource
==28223==
==28223== HEAP SUMMARY:
==28223==     in use at exit: 0 bytes in 0 blocks
==28223==   total heap usage: 195 allocs, 195 frees, 107,934 bytes allocated
==28223==
==28223== All heap blocks were freed -- no leaks are possible
==28223==
==28223== For counts of detected and suppressed errors, rerun with: -v
==28223== ERROR SUMMARY: 2 errors from 2 contexts (suppressed: 4 from 4)

Mateusz Jurczyk <j00ru>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #25130:  10x20gmb.bdf.asan.24.6 added by j00ru (35KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by wl (Updated the item)
  • -email is unavailable- added by j00ru (Submitted the item)
  • -email is unavailable- added by j00ru
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-02-26 wl StatusNone Fixed
        PrivacyPrivate Public
        Open/ClosedOpen Closed
        Planned ReleaseNone 2.4.9
    2012-02-25 wl Assigned toNone wl
    2012-02-23 j00ru Attached File- Added 10x20gmb.bdf.asan.24.6, #25130
        Carbon-Copy- Added j00ru

    Back to the top


    Powered by Savane 3.9