bugGPSD - Bugs: bug #35765, gpsctl should use pselect() where...

 
 

bug #35765: gpsctl should use pselect() where available

Submitted by:  Andrew Evdokimov <elahi>
Submitted on:  Thu 08 Mar 2012 06:52:35 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Need Info
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 05 Apr 2012 09:56:36 PM UTC, comment #2:

pselect is now used when possible, but with a timeout. I tried leaving out the timeout, but just got consistent failures.

I committed this change because it produces better behavior in the presence of signals. You may need to modify it to speed up device recognition; I'd try, but I don't undetstand the slowdown you're seeing.

Eric S. Raymond <esr>
Project Administrator
Fri 09 Mar 2012 07:28:01 AM UTC, comment #1:

I don't see how pselect will address the problem of long autodetection. Therefore this is going to be low on my priority list; it will move up if you can convince me that it's likely to fix that bug.

But I'll certainly take a pselect patch if you can generate one; it would be a good code cleanup even if it doesn't fix this problem.

Eric S. Raymond <esr>
Project Administrator
Thu 08 Mar 2012 06:52:35 PM UTC, original submission:

gpsctl in low-level access mode uses 2-second timeout to select() in get_packet(). As some devices take many cycles to autodetect correctly (for instance, ~350 packets need to be analyzed for my BU-353 SiRF device until it gets recognized), this logic will cause gpsctl to take 10-15 minutes to autodetect the device.

Using pselect() where available (as gpsd does) will help with this issue.

Andrew Evdokimov <elahi>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by esr (Posted a comment)
  • -unavailable- added by elahi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 23 May 2012 06:22:00 AM UTCesrOpen/ClosedOpen=>Closed
    Tue 17 Apr 2012 08:39:41 AM UTCesrStatusReady For Test=>Need Info
    Thu 05 Apr 2012 09:56:49 PM UTCesrStatusNone=>Ready For Test

    Back to the top


    Powered by Savane 3.1-cleanup1