buglwIP - A Lightweight TCP/IP stack - Bugs: bug #35809, PPP GetMask(): Compiler warning on...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #35809: PPP GetMask(): Compiler warning on big endian, possible bug on little endian system

Submitted by:  Bostjan Meglic <bostjanm>
Submitted on:  Mon 12 Mar 2012 03:23:23 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: Compiler WarningStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: 1.4.0

Mon 12 Mar 2012 03:40:38 PM UTC, comment #2:

Fixed in both branches (DEVEL-1_4_1 and master).

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Mon 12 Mar 2012 03:34:35 PM UTC, comment #1:

Next time you report a bug, please tell us where it is (you haven't provided that information anywhere but in the patch file).

Other than that, that's a real bug which is in there since ppp was initially added (in 2003).

Thanks for reporting.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Mon 12 Mar 2012 03:23:23 PM UTC, original submission:

I have BIG_ENDIAN system, so htonx()/ntohx() functions are empty.
But I still got a compiler warning about 'expression has no effect' on the following line:

htonl(addr);

Shouldn't that read as

addr = htonl(addr); ?

Bostjan Meglic <bostjanm>

 

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by bostjanm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 12 Mar 2012 03:40:38 PM UTCgoldsimonStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Mon 12 Mar 2012 03:34:35 PM UTCgoldsimonStatusNone=>In Progress
      Assigned toNone=>goldsimon
      Planned Release=>1.4.1
      SummaryCompiler warning on big endian, possible bug on little endian system=>PPP GetMask(): Compiler warning on big endian, possible bug on little endian system
    Mon 12 Mar 2012 03:23:58 PM UTCbostjanmAttached File-=>Added Store-computed-value-addr-back-to-the-variable.patch, #25334

    Back to the top


    Powered by Savane 3.1-cleanup1