buglwIP - A Lightweight TCP/IP stack - Bugs: bug #35817, do_connect() invalidly signals...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #35817: do_connect() invalidly signals op_completed for UDP/RAW with LWIP_TCPIP_CORE_LOCKING==1

Submitted by:  hanhui <hanhui03>
Submitted on:  Mon 12 Mar 2012 05:07:46 PM UTC  
 
Category: sockets/netconnSeverity: 3 - Normal
Item Group: Crash ErrorStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: CVS Head

Sun 25 Mar 2012 12:57:13 PM UTC, comment #4:

Fixed in master (1.4.1 branch is not affected), thanks for reporting.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Sun 25 Mar 2012 12:52:41 PM UTC, comment #3:

Updated summary to tell something about the bug.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Tue 13 Mar 2012 05:57:57 PM UTC, comment #2:

Great! I agree add a flag in msg struct.

hanhui <hanhui03>
Tue 13 Mar 2012 04:36:37 PM UTC, comment #1:

This has been introduced since 1.4.1 was branched, so we don't need to fix it for that release.

It sounds like we need to make an equivalent change to do_connect so that it only calls op_completed when necessary. Or have a flag in msg that indicates that this is needed.

Kieran Mansley <kieranm>
Project Administrator
Mon 12 Mar 2012 05:07:46 PM UTC, original submission:

netconn_connect()
{
if (tcp) {
msg.function = do_connect;
tcpip_apimsg(&msg);

} else if (udp or raw) {
TCPIP_APIMSG(...do_connect...);
}
}

in core lock mode, tcpip_apimsg() need signal op_completed, but TCPIP_APIMSG() does not needed!

BUT:do_connect() always signal the op_completed! here is a BUG! that will cause a faulty behaviour!

hanhui <hanhui03>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by kieranm (Posted a comment)
  • -unavailable- added by hanhui03 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 25 Mar 2012 12:57:13 PM UTCgoldsimonOpen/ClosedOpen=>Closed
    Sun 25 Mar 2012 12:57:12 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
    Sun 25 Mar 2012 12:52:41 PM UTCgoldsimonSummarynetconn_connect or do_connect() have a BIG bug!!! =>do_connect() invalidly signals op_completed for UDP/RAW with LWIP_TCPIP_CORE_LOCKING==1
    Tue 13 Mar 2012 04:36:54 PM UTCkieranmPlanned Release=>1.5.0

    Back to the top


    Powered by Savane 3.1-cleanup1