buglwIP - A Lightweight TCP/IP stack - Bugs: bug #35875, #define ⇒ enum?

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #35875: #define ⇒ enum?

Submitted by:  Markus Elfring <elfring>
Submitted on:  Sat 17 Mar 2012 02:52:43 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: Feature RequestStatus: Wont Fix
Privacy: PublicAssigned to: None
Open/Closed: ClosedPlanned Release: None
lwIP version: 1.4.0

Tue 20 Mar 2012 08:08:24 PM UTC, comment #2:

The pros and cons of this have been discussed on the lwip-devel list (unfortunately not on this bug!). There seem to be advantages to both approaches. Let's stick with what we've got unless there is a compelling reason to switch.

Kieran Mansley <kieranm>
Project Administrator
Sun 18 Mar 2012 12:30:34 PM UTC, comment #1:

I don't think so: the defines are used for good reason as enums are sizeof(int) by default and we are using u8_t in many places.

Simon Goldschmidt <goldsimon>
Project Administrator
Sat 17 Mar 2012 02:52:43 PM UTC, original submission:

Would you like to replace any more defines for constant values by enumerations to stress their relationships?

Markus Elfring <elfring>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by kieranm (Posted a comment)
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by elfring (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 20 Mar 2012 08:08:24 PM UTCkieranmStatusNone=>Wont Fix
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1