buglwIP - A Lightweight TCP/IP stack - Bugs: bug #36170, dhcp array access out of bounds.

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #36170: dhcp array access out of bounds.

Submitted by:  zg <zg0>
Submitted on:  Fri 13 Apr 2012 11:45:33 PM UTC  
 
Category: TCPSeverity: 3 - Normal
Item Group: Compiler WarningStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: 1.4.0

Thu 03 May 2012 06:23:11 PM UTC, comment #1:

Strictly speaking, you're correct. But it doesn't have an impact unless the global variable 'dhcp_rx_options_given' happens to be at the end of some memory segment and you are running on hardware that checks invalid access. I've fixed it, anyway, thanks for reporting!

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Fri 13 Apr 2012 11:45:33 PM UTC, original submission:

in dhcp.c:
while(dhcp_option_given(dhcp, DHCP_OPTION_IDX_DNS_SERVER + n) && (n < DNS_MAX_SERVERS)) {
bound check must be before access, isnt it?

zg <zg0>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by zg0 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 03 May 2012 06:23:11 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1