buglwIP - A Lightweight TCP/IP stack - Bugs: bug #36317, PPP with PPPoE reauth not working

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #36317: PPP with PPPoE reauth not working

Submitted by:  Sylvain Rochet <gradator>
Submitted on:  Thu 26 Apr 2012 02:43:50 PM UTC  
 
Category: PPPSeverity: 3 - Normal
Item Group: Faulty BehaviourStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: ClosedPlanned Release: None
lwIP version: CVS Head

Thu 22 May 2014 07:40:55 PM UTC, comment #4:

ppp-new branch merged in master

Sylvain Rochet <gradator>
Project Member
Mon 04 Jun 2012 08:13:03 PM UTC, comment #3:

Applied in ppp-new branch.

Sylvain Rochet <gradator>
Project Member
Fri 04 May 2012 01:03:56 PM UTC, comment #2:

You are right, don't know why yet, but it works without the change in fsm.c

Sylvain Rochet <gradator>
Project Member
Thu 03 May 2012 07:08:09 PM UTC, comment #1:

As I said in the other bug, the pop code (apart from ppp.c and ppp_oe.c) are more or less copied directly from samba pppd. Your patch modifies fsm.c, which is a thing I want to avoid, as it looks like we'd be fixing a bug in the original pppd..

Can you go into more details why that new line in fsm.c is necessary? Doesn't it have an impact on PPPOS, too? You're only speaking of PPPOE in the summary...

Simon Goldschmidt <goldsimon>
Project Administrator
Thu 26 Apr 2012 02:43:50 PM UTC, original submission:

Hi,

When a ReAuth request is sent (CHAP Challenge received while already received previously for example) and when using PPPoE, the PPP stack fails to restart the auth to the beginning and wrongfully shutdown the PPPoE session instead of keeping it alive due to a misunderstanding of the difference between pppLinkDown() and pppLinkTerminated() in netif/ppp/ppp.c

This can be a problem when using DSL providers chaining LAC+LNS servers, for example when using L2TP tunnel switching/forwarding technique, which cause the PPP auth to be required on all L2TP forwarders, in order to let the LAC+LNS find the next L2TP next-hop by requesting a Radius server using the realm part of the auth string.

Here is a patch that fix this behavior, which doesn't shutdown the PPPoE while a ReAuth request is sent, and which set the correct flag to the LCP field.

Sylvain

Sylvain Rochet <gradator>
Project Member

 

Attached Files
file #25743:  pppoe-reauth-fix.patch added by gradator (891B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by gradator (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 22 May 2014 07:40:55 PM UTCgradatorStatusNone=>Fixed
      Open/ClosedOpen=>Closed
      Planned Release=>1.5.0
    Mon 14 Jan 2013 09:06:16 PM UTCgoldsimonCategoryNone=>PPP
    Thu 26 Apr 2012 02:43:50 PM UTCgradatorAttached File-=>Added pppoe-reauth-fix.patch, #25743

    Back to the top


    Powered by Savane 3.1-cleanup1