buglwIP - A Lightweight TCP/IP stack - Bugs: bug #36424, PPPoED, packets with error message...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #36424: PPPoED, packets with error message tag are silently tossed

Submitted by:  Sylvain Rochet <gradator>
Submitted on:  Mon 07 May 2012 02:58:50 PM UTC  
 
Category: PPPSeverity: 3 - Normal
Item Group: Faulty BehaviourStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: ClosedPlanned Release: None
lwIP version: CVS Head

Thu 22 May 2014 07:41:43 PM UTC, comment #2:

ppp-new branch merged in master

Sylvain Rochet <gradator>
Project Member
Mon 04 Jun 2012 08:12:33 PM UTC, comment #1:

Applied in ppp-new branch.

Sylvain Rochet <gradator>
Project Member
Mon 07 May 2012 02:58:50 PM UTC, original submission:

If a PPPoED message with an optional error message is received, it is silently tossed due to the "goto done;" which goes to the far end of the function.

We can as well use a "goto breakbreak;" or let the loop finish because the message is always the latest tag.

Here is a patch that fix this behavior, it also remove the useless errortag variable and therefore save 4B on the stack.

Sylvain Rochet <gradator>
Project Member

 

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Updated the item)
  • -unavailable- added by gradator (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 22 May 2014 07:41:43 PM UTCgradatorStatusNone=>Fixed
      Open/ClosedOpen=>Closed
      Planned Release=>1.5.0
    Mon 14 Jan 2013 09:06:46 PM UTCgoldsimonCategoryNone=>PPP
    Mon 07 May 2012 02:58:50 PM UTCgradatorAttached File-=>Added lwip-pppoed-packet-with-error-message-tag-silently-tossed.patch, #25813

    Back to the top


    Powered by Savane 3.1-cleanup1