bugWeeChat - Bugs: bug #36776, Correct manpage install path

 
 

bug #36776: Correct manpage install path

Submitted by:  Simon <foobar23>
Submitted on:  Tue 03 Jul 2012 02:01:40 PM UTC  
 
Category:  documentation Severity:  3 - Normal
Item Group:  documentation Status:  Fixed
Privacy:  Public Assigned to:  Sebastien Helleu <flashcode>
Originator Name:  Open/Closed:  Closed
Release:  0.3.8 IRC nick: 

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 05 Jul 2012 10:52:47 AM UTC, comment #4: 

Thank you, that should do the trick for now.

By the way, the reason you can't find CMAKE_INSTALL_MANDIR is that you need GNUInstallDirs.cmake in /usr/share/cmake-$VERSION/Modules
(installed by the cmake-data package).

It's strange though, as this gets installed by Debian/sid (cmake on Squeeze is too old to have this).

Anyway, having MANDIR as a cmake option is works for me. Thanks again!

Simon <foobar23>
Thu 05 Jul 2012 10:09:30 AM UTC, comment #3: 

Done.

The new option MANDIR points to "${SHAREDIR}/man" by default.

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Tue 03 Jul 2012 04:15:42 PM UTC, comment #2: 

I thought CMAKE_INSTALL_MANDIR would be a builtin variable. The cmake patch that got committed to OpenBSD and the cmake documentation I posted at least implied that. http://www.openbsd.org/cgi-bin/cvsweb/~checkout~/ports/devel/cmake/patches/patch-Modules_GNUInstallDirs_cmake?rev=1.1;content-type=text%2Fplain

I really don't know if that's weechat/cmake specific or if it's a Debian/cmake problem...

But for now I guess it would help (at least on OpenBSD) to use the MANDIR option approach, but with MAINDIR being set to ${SHAREDIR}/man/man1 as a default, so existing setups do not break?

Simon <foobar23>
Tue 03 Jul 2012 02:11:49 PM UTC, comment #1: 

Hi,

Thank you for patches.

I agree there is a little problem with path in doc/CMakeLists.txt, but for me your patches are not working: the CMAKE_INSTALL_MANDIR is not defined here (using cmake 2.8.9-rc1 on debian sid).
Maybe it would need some extra changes to have that defined, do you have time to investigate this problem ? (otherwise tell me, I'll try to look)

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Tue 03 Jul 2012 02:01:40 PM UTC, original submission:  

While creating the OpenBSD port I stumbled upon the "bug" that weechat does not install the man page to the correct path.

In doc/CMakeLists.txt you hardcode ${SHAREDIR}/man/man1 which is not always correct (under OpenBSD manpages are in /usr/local/man not /usr/local/share/man for example).

According to this: http://www.cmake.org/cmake/help/v2.8.8/cmake.html
cmake sets a variable called CMAKE_INSTALL_MANDIR which should be used in this case.

I attached two approaches to this:
 o just replace SHAREDIR with CMAKE_INSTALL_MANDIR in doc/CMakeLists.txt
 o make MANDIR a new cmake option (using CMAKE_INSTALL_MANDIR as default)

Simon <foobar23>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #26147:  0001-doc-new-cmake-option-MANDIR.patch added by foobar23 (1KiB - application/octet-stream)
file #26144:  0001-doc-install-manpage-to-CMAKE_INSTALL_MANDIR.patch added by foobar23 (888B - application/octet-stream - Patches)
file #26145:  0001-doc-new-cmake-option-MANDIR.patch added by foobar23 (1KiB - application/octet-stream - Patches)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by flashcode (Posted a comment)
  • -email is unavailable- added by foobar23 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-09-29 flashcode Open/ClosedOpen => Closed
    2012-07-05 flashcode StatusNeed Info => Fixed
        Release2.4-dev => 0.3.8
    2012-07-03 flashcode CategoryNone => documentation
        StatusNone => Need Info
        Assigned toNone => flashcode
    2012-07-03 foobar23 Attached File- => Added 0001-doc-install-manpage-to-CMAKE_INSTALL_MANDIR.patch, #26146
        Attached File- => Added 0001-doc-new-cmake-option-MANDIR.patch, #26147
    2012-07-03 foobar23 Attached File- => Added 0001-doc-install-manpage-to-CMAKE_INSTALL_MANDIR.patch, #26144
        Attached File- => Added 0001-doc-new-cmake-option-MANDIR.patch, #26145

    Back to the top


    Powered by Savane 3.5