buggnokii - Bugs: bug #36799, Please add --no-delete option

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #36799: Please add --no-delete option

Submitted by:  Johannes Matschke <butesa>
Submitted on:  Fri 06 Jul 2012 02:23:43 PM UTC  
 
Category: smsdSeverity: 3 - Normal
Item Group: feature requestStatus: Wont Fix
Privacy: PublicAssigned to: Jan Derfinak <ja>
Open/Closed: Closed

(Jump to the original submission Jump to the original submission)

Wed 18 Jul 2012 06:47:49 AM UTC, comment #6:

Hi Johannes.

As I previously wrote I don't like the idea because it will keep phone busy for ever. I don't think it is good for debuging because it doesn't simulate the standard smsd behaviour. Daniele's suggestion about Fake driver seems to me as better option.

Jan

Jan Derfinak <ja>
Project MemberIn charge of this item.
Tue 17 Jul 2012 03:54:41 PM UTC, comment #5:

So maybe smsd should quit after one iteration.

But for me it would also be fine if smsd gets into an infinite loop while trying to clear its queue, so I have to stop it with Crtl+C.

Now I comment out the delete command to do my test, that works fine. But with such a command line option, I wouldn't need to compile smsd myself, instead I could use the version of my distribution.

Johannes Matschke <butesa>
Sat 07 Jul 2012 02:43:36 PM UTC, comment #4:

The AT protocol automatically marks an SMS as read in the phone, but we don't know how to do that with FBUS on recent Nokias that don't support AT (Series 40 3rd Ed. and later); AFAIR older Nokias automatically marked SMS as read but we never documented that.

Anyway testing with the fake driver has some advantages (full control over PDU and over timing of arrival).
http://wiki.gnokii.org/index.php/Fake_driver

Daniele Forsi <dforsi>
Project Administrator
Sat 07 Jul 2012 02:13:48 PM UTC, comment #3:

Hello.

Johannes Matschke wrote:
"The MySQL module can detect if an message is already in the database."

This is not true. Smsd cannot detect if sms is already in DB. It reads sms from phone and it tries to insert it to DB. This will fail because DB has unique key which disallow inserting of the same message. So smsd will read sms in the next loop with the same result. It never sleeps because it will never be unable to clear the queue. The only solution I can imagine is marking read sms in phone and then skiping read messages. But I don't know if this is possible.

Jan

Jan Derfinak <ja>
Project MemberIn charge of this item.
Fri 06 Jul 2012 08:29:41 PM UTC, comment #2:

The MySQL module can detect if an message is already in the database. If you comment out the deleting command in lowlevel.c, you will see this log output:

MSG already stored in database.
Duplicated sms from <telephone number>.

smsd does nothing until you delete this message from the database.

I think the postgres and sqlite modules will do the same thing, but I didn't test. The file module gives the same messages again in each loop, so its up to the used action to detect duplicate messages.

Johannes Matschke <butesa>
Fri 06 Jul 2012 08:00:51 PM UTC, comment #1:

And what should smsd do on the next loop? Read and store the same messages?

Pawel Kot <pkot>
Project Administrator
Fri 06 Jul 2012 02:23:43 PM UTC, original submission:

Please add a --no-delete option to smsd. When given on command line, smsd should not delete any message from the phone. That would be very useful for testing.

Johannes Matschke <butesa>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by dforsi (Posted a comment)
  • -unavailable- added by ja (Posted a comment)
  • -unavailable- added by pkot (Posted a comment)
  • -unavailable- added by butesa (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 26 Aug 2012 10:24:03 PM UTCjaOpen/ClosedOpen=>Closed
    Wed 18 Jul 2012 06:47:49 AM UTCjaStatusNone=>Wont Fix
    Fri 06 Jul 2012 08:00:51 PM UTCpkotAssigned toNone=>ja

    Back to the top


    Powered by Savane 3.1-cleanup1