bugpyFormex - Bugs: bug #36806, coords.projectOnSurface() fails...

 
 

bug #36806: coords.projectOnSurface() fails with ignore_errors=True

Submitted by:  Tran Phuong Toan <phuotran>
Submitted on:  Sat 07 Jul 2012 01:43:21 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: Functionality errorStatus: Fixed
Privacy: PublicAssigned to: Benedict Verhegghe <bverheg>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 12 Jul 2012 01:47:36 PM UTC, comment #4:

These two concerns are fixed in revision 2370.

If not a single point is projected on the surface, an error is raised. (There is no way to define an approximate position of the
projection).

Benedict Verhegghe <bverheg>
Project AdministratorIn charge of this item.
Thu 12 Jul 2012 11:53:39 AM UTC, comment #3:

When the point which doesn't have an intersection with the surface is not the last one of the Coords list (let's say it has index i in the list), the projection of the i+1 point (which has an intersection) seems not to be correct. For this i+1 point, the second cut returns an empty Coords and, therefore, this point is considered not having an intersection (see attached file).

Also, when none of the points in the Coords list has an intersection with the surface, an error is raised because Coords.concatenate() cannot concatenate empty arrays.

(file #26188)

Tran Phuong Toan <phuotran>
Project Member
Wed 11 Jul 2012 05:54:45 PM UTC, comment #2:

In revision 2368, the ignore_errors parameter has been replaced with a 'missing' parameter, specifying how to compute the result for points that do not have a projection. The result is now always congruent with the input.

I think we can close the bug. (Reopen if you feel something is not correct or can be improved.)

Benedict Verhegghe <bverheg>
Project AdministratorIn charge of this item.
Tue 10 Jul 2012 05:49:04 PM UTC, comment #1:

This has been fixed in revision 2365. Points that can not be projected are simply left out.

An improvement might be to also return an index identifying which points actually have a projection on the surface. Therefore I left this bug open and marked it in progress.

Benedict Verhegghe <bverheg>
Project AdministratorIn charge of this item.
Sat 07 Jul 2012 01:43:21 PM UTC, original submission:

With ignore_errors=True, projectOnSurface is supposed to return NaN values for projective lines not cutting the surface and not raise any error. But it raises an error anyway.

Tran Phuong Toan <phuotran>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #26188:  testProjectOnSurface.py added by phuotran (8KiB - text/x-python)
file #26162:  testProjectOnSurface.py added by phuotran (4KiB - text/x-python)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bverheg (Posted a comment)
  • -unavailable- added by phuotran (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 12 Jul 2012 01:47:36 PM UTCbverhegStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Thu 12 Jul 2012 11:53:39 AM UTCphuotranAttached File-=>Added testProjectOnSurface.py, #26188
      StatusFixed=>In Progress
      Open/ClosedClosed=>Open
    Wed 11 Jul 2012 05:54:45 PM UTCbverhegStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Tue 10 Jul 2012 05:49:04 PM UTCbverhegItem GroupNone=>Functionality error
      StatusNone=>In Progress
      Assigned toNone=>bverheg
    Sat 07 Jul 2012 01:43:21 PM UTCphuotranAttached File-=>Added testProjectOnSurface.py, #26162

    Back to the top


    Powered by Savane 3.1-cleanup1