bugpyFormex - Bugs: bug #36963, partitionByAngle

 
 

bug #36963: partitionByAngle

Submitted by:  gianluca de santis <gianlucadesi>
Submitted on:  Thu 26 Jul 2012 01:00:19 PM UTC  
 
Category: NoneSeverity: 4 - Important
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Benedict Verhegghe <bverheg>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 30 Jul 2012 07:04:43 PM UTC, comment #3:

This is fixed in revision 2382. The fix is based on the new functionality of Mesh.adjacency(), allowing the specification of a mask to select only some edges as acive connections.

Benedict Verhegghe <bverheg>
Project AdministratorIn charge of this item.
Fri 27 Jul 2012 07:46:15 AM UTC, comment #2:

The problem is that the 'okedges' feature is missing in the Connectivity frontWalk. I will add it.
There was a second problem with a missing 'self' argument, but
that is easy to fix ;)

Benedict Verhegghe <bverheg>
Project AdministratorIn charge of this item.
Thu 26 Jul 2012 05:25:36 PM UTC, comment #1:

Either there is an error in edgeFront/walkEdgeFront, or the results are not used correctly in partitionByAngle.
This is the error that should be detected (and fixed).

It is not a good idea to restore the old edgeFront/walkEdgeFront, because those for a general Mesh should work fine for a TriSurface as well. While an individual user can certainly restore some older functions in his private tree to get a correct functinality, we should in general not check in such changes which are walking away from the correct direction (which is towards a general edgeFront/walkEdgeFront for all Meshes).

Benedict Verhegghe <bverheg>
Project AdministratorIn charge of this item.
Thu 26 Jul 2012 01:00:19 PM UTC, original submission:

in triSurface.py the function partitionByAngle was broken because of the changes in the edgeFront and walkEdgeFront (replaced in connectivity.py).
I have restored the old functions (which were commented) and now it works again.
I have indicated the changes with some comments.

gianluca de santis <gianlucadesi>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bverheg (Posted a comment)
  • -unavailable- added by gianlucadesi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 30 Jul 2012 07:04:43 PM UTCbverhegStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1