bugWeeChat - Bugs: bug #37432, xfer plugin doesn't follow recv...

 
 

bug #37432: xfer plugin doesn't follow recv manpage recommendation when checking errno

Submitter:  None
Submitted:  Sun 23 Sep 2012 09:00:40 PM UTC
 
Category:  xfer plugin Severity:  3 - Normal
Item Group:  other Status:  Fixed
Privacy:  Public Assigned to:  flashcode
Originator Name:  Originator Email:  * -email is unavailable-
Open/Closed:  Closed Release:  * 0.3.8
IRC nick: 
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Sun 23 Sep 2012 09:00:40 PM UTC, original submission:  

For file plugins/xfer/xfer-dcc.c:

76c76
<                     ((num_read != -1) || (errno != EAGAIN)))
---

>                     ((num_read != -1) || ((errno != EAGAIN) && (errno != EWOULDBLOCK))))

128c128
<                     if (errno == EAGAIN)
---

>                     if ((errno == EAGAIN)  || (errno == EWOULDBLOCK))

209c209
<             if ((errno == EAGAIN) || (errno == EINTR))
---

>             if ((errno == EAGAIN) || (errno == EWOULDBLOCK) || (errno == EINTR))


I guess it is the reason some xfer transfers fail with an XFER_ERROR_RECV_BLOCK, even though there should be no reason to fail.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by flashcode (Updated the item)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-09-29 flashcode Open/ClosedOpen Closed
    2012-09-24 flashcode StatusNone Fixed
        Assigned toNone flashcode
        Release3.3-dev 0.3.8

    Back to the top


    Powered by Savane 3.9