buglwIP - A Lightweight TCP/IP stack - Bugs: bug #37549, Need to disable HISADDR check for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #37549: Need to disable HISADDR check for PPP

Submitted by:  Mark Lakata <lakata>
Submitted on:  Thu 11 Oct 2012 05:54:23 PM UTC  
 
Category: PPPSeverity: 3 - Normal
Item Group: Change RequestStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: ClosedPlanned Release: None
lwIP version: 1.4.0

Thu 22 May 2014 07:43:15 PM UTC, comment #3:

ppp-new branch merged in master

Sylvain Rochet <gradator>
Project Member
Thu 11 Oct 2012 06:13:54 PM UTC, comment #2:

ppp-new branch, based from latest pppd git master and various paths, use:

if (ho->hisaddr == 0 && !pcb->settings.noremoteip) {
ho->hisaddr = htonl(0x0a404040);
ppp_warn("Could not determine remote IP address: defaulting to %I",
ho->hisaddr);
}

Which seem a better approach than your suggested change against the current lwIP release.

Sylvain Rochet <gradator>
Project Member
Thu 11 Oct 2012 05:59:14 PM UTC, comment #1:

Here are references to other people finding and fixing this issue:

http://mbed.org/users/mbed_official/code/lwip/rev/f71f5d9d5846

Similar OpenBSD Issue

http://www.monkey.org/openbsd/archive2/misc/200503/msg00224.html

Discussions on LWIP mailing

http://lwip.100.n7.nabble.com/strange-TCP-ack-td8177.html#a8185
http://lwip.100.n7.nabble.com/Remote-address-with-PPP-Connection-td9631.html

Mark Lakata <lakata>
Thu 11 Oct 2012 05:54:23 PM UTC, original submission:

The function ipcp_up() checks the HISADDR field is not zero, and aborts the PPP connection if it is.

This is an optional field and many 3G providers do not supply this field. There should be a compile time option to disable this check.

The suggested change is adding a compiler flag, such as PPP_HISADDR_WARNING

if (ho->hisaddr == 0) {
#ifdef PPP_HISADDR_WARNING
IPCPDEBUG(LOG_ERR, ("Warning: Remote IP address is 0\n"));
#else
IPCPDEBUG(LOG_ERR, ("Could not determine remote IP address\n"));
ipcp_close(f->unit, "Could not determine remote IP address");
return;
#endif
}

Mark Lakata <lakata>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Updated the item)
  • -unavailable- added by gradator (Posted a comment)
  • -unavailable- added by lakata (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 22 May 2014 07:43:15 PM UTCgradatorStatusNone=>Fixed
      Open/ClosedOpen=>Closed
      Planned Release=>1.5.0
    Mon 14 Jan 2013 09:04:55 PM UTCgoldsimonCategoryContrib=>PPP

    Back to the top


    Powered by Savane 3.1-cleanup1