bugWeeChat - Bugs: bug #37764, Security problem with untrusted...


bug #37764: Security problem with untrusted command given to hook_process in plugin API

Submitter:  Sebastien Helleu <flashcode>
Submitted:  Sun 18 Nov 2012 09:25:51 AM UTC
Category:  plugins Severity:  6 - Security
Item Group:  security Status:  Fixed
Privacy:  Public Assigned to:  flashcode
Originator Name:  Open/Closed:  Closed
Release:  * 0.3.9 IRC nick:  FlashCode
* Mandatory Fields

Add a New Comment Rich Markup

Sun 18 Nov 2012 12:32:02 PM UTC, comment #1: 

Fixed in devel and new stable version has been released.
Upgrade is HIGHLY recommended.

Workaround with a non patched version: remove/unload all scripts calling function hook_process (for maximum safety).

Sebastien Helleu <flashcode>
Group administrator
Sun 18 Nov 2012 09:25:51 AM UTC, original submission:  

When a plugin or script gives untrusted command to hook_process, there could be a security problem, because WeeChat uses shell to execute command.

Solution: split arguments and execute command using this array of arguments, without calling the shell. Therefore arguments are not expanded by shell.

Sebastien Helleu <flashcode>
Group administrator


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by flashcode (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.


    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-01-20 flashcode Open/ClosedOpen Closed
    2012-11-18 flashcode PrivacyPrivate Public
    2012-11-18 flashcode StatusIn Progress Fixed

    Back to the top

    Powered by Savane 3.13-b921.
    Corresponding source code