buglwIP - A Lightweight TCP/IP stack - Bugs: bug #37893, Unused variables in tcp_out...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #37893: Unused variables in tcp_out (tcphdr)

Submitted by:  Krzysztof Wesołowski <kwesoly>
Submitted on:  Mon 10 Dec 2012 11:16:26 AM UTC  
 
Category: TCPSeverity: 3 - Normal
Item Group: Compiler WarningStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: 1.4.0

Mon 14 Jan 2013 08:07:34 PM UTC, comment #1:

Fixed, thanks for reporting.

BTW: as a result of lwIP's many configuration options, there may be a lot more unused variables in some configurations.

Plus MS Visual Studio 2008 did not report 'tcphdr' as unused because it is assigned (although never read)...

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Mon 10 Dec 2012 11:16:26 AM UTC, original submission:

Some variables are conditionally unused. This causes compiler warning with specific configuration options.

Putting varible declaration and assignments into same conditional directives solves problem.

I have attached patch for such changes in tcp_out.c.

Krzysztof Wesołowski <kwesoly>

 

Attached Files
file #27065:  tcp_out.c.patch added by kwesoly (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by kwesoly (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 14 Jan 2013 08:07:34 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed
    Mon 10 Dec 2012 11:16:26 AM UTCkwesolyAttached File-=>Added tcp_out.c.patch, #27065

    Back to the top


    Powered by Savane 3.1-cleanup1