bugranger - Bugs: bug #37929, Crash while open bookmark

 
 

bug #37929: Crash while open bookmark

Submitted by:  looper <looper>
Submitted on:  Sat 15 Dec 2012 02:36:37 PM UTC  
 
Severity: 3 - NormalStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 15 Dec 2012 04:38:01 PM UTC, comment #3:

Thanks

Roman Z. <hut>
Project Administrator
Sat 15 Dec 2012 04:26:43 PM UTC, comment #2:

You're right, my test directory was empty. The bug is fixed with last commit, thank you!

looper <looper>
Sat 15 Dec 2012 04:18:15 PM UTC, comment #1:

I get this error only if I open a bookmark while in an empty directory, I hope it's the same issue that you described. I pushed a fix to ranger-git, can you tell me if it works now?

Roman Z. <hut>
Project Administrator
Sat 15 Dec 2012 02:36:37 PM UTC, original submission:

Hello!
With all last commits installed I experienced a problem.

Steps to reproduce:
1. Run ranger with any directory as parameter, e.g. 'ranger /home'.
2. Have ranger launched, try to open any saved bookmark, and ranger crashes:

ranger version: 1.5.5, executed with python 2.7.3rc2
Locale: en_US.UTF-8
Current file: None
Traceback (most recent call last):
File "/home/loop/.ranger/ranger/core/main.py", line 133, in main
fm.loop()
File "/home/loop/.ranger/ranger/core/fm.py", line 263, in loop
ui.handle_input()
File "/home/loop/.ranger/ranger/gui/ui.py", line 208, in handle_input
self.handle_key(key)
File "/home/loop/.ranger/ranger/gui/ui.py", line 144, in handle_key
self.press(key)
File "/home/loop/.ranger/ranger/gui/ui.py", line 159, in press
quantifier=keybuffer.quantifier)
File "/home/loop/.ranger/ranger/core/actions.py", line 169, in execute_console
escape=cmd.escape_macros_for_shell)
File "/home/loop/.ranger/ranger/core/actions.py", line 184, in substitute_macros
macros = self._get_macros()
File "/home/loop/.ranger/ranger/core/actions.py", line 212, in _get_macros
macros['s'] = [fl.basename for fl in self.fm.thistab.get_selection()]
AttributeError: 'NoneType' object has no attribute 'basename'

looper <looper>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by hut (Posted a comment)
  • -unavailable- added by looper (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 15 Dec 2012 04:38:01 PM UTChutOpen/ClosedOpen=>Closed
    Sat 15 Dec 2012 04:18:15 PM UTChutStatusNone=>Fixed

    Back to the top


    Powered by Savane 3.1-cleanup1