bugIdentica mode - Bugs: bug #38320, Change handling of faces in...


bug #38320: Change handling of faces in timelines.

Submitter:  Jason F. McBrayer <jfmcbrayer>
Submitted:  Tue 12 Feb 2013 08:57:21 PM UTC
Category:  None Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup

Tue 12 Feb 2013 08:57:21 PM UTC, original submission:  

For some time now, the way faces are handled in identica-mode has bothered me. Basically, you set the background in a defcustom'ed variable. The faces themselves get created on startup, and have their attributes set when the timeline is rendered. One effect of this is that customize-face on those faces is ignored.

I've removed those defcustom'ed variables, and replaced them with defface'd faces, with the same default values. IMO, this is more consistent with normal face usage. The only loss, I think, is that it may be less visible to users who (customize-group 'identica).

I'd like to replace the merge-text-attribute calls with just setting the face, so that you can customize any attributes of the face and have it be applied properly, but the docstring on merge-text-attribute suggests that it's not that simple.

Jason F. McBrayer <jfmcbrayer>
Group Member


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by jfmcbrayer (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.


    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-02-12 jfmcbrayer Attached File- Added 0003-Update-handling-of-faces-to-respect-customization.patch, #27454

    Back to the top

    Powered by Savane 3.13-c54d.
    Corresponding source code