Add a New Comment (Rich Markup)
Thanks for the patch, committed.
The charset plugin is not built on OS X because cmake thinks libiconv isn't available, which it is (on 10.8.2 at least, it is in /usr/lib). I was trying to figure this out a while ago, and discovered that swapping the order of the CHECK_LIBRARY_EXISTS calls in cmake/FindIconv.cmake (oddly) caused cmake to find libiconv like it should. I took a closer look at this today, and discovered that if the first CHECK_LIBRARY_EXISTS call fails, the second call doesn't actually set ICONV_FOUND to true for some reason (which causes cmake to think that the library isn't available). I have attached a patch (fix-libiconv-checks.patch) that resolves this problem by altering the check logic such that both checks actually matter.
(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)
Attach Files: Comment:
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Only logged-in users can vote.
Please enter the title of George Orwell's famous dystopian book (it's a date):
Follow 5 latest changes.
Copyright © 2023 Free Software Foundation, Inc. Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved. The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team. Source Code
Powered by Savane 3.11