bugWeeChat - Bugs: bug #38343, Guile script with a hook_modifier...

 
 

bug #38343: Guile script with a hook_modifier on "weechat_print" crashes WeeChat

Submitter:  None
Submitted:  Sat 16 Feb 2013 07:19:02 PM UTC
 
Category:  script API plugins Severity:  3 - Normal
Item Group:  crash Status:  Fixed
Privacy:  Public Assigned to:  flashcode
Originator Name:  Justin C Originator Email:  * -email is unavailable-
Open/Closed:  Closed Release:  * 0.4.0
IRC nick:  boxofrox
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Tue 19 Feb 2013 05:57:51 PM UTC, comment #1: 

I have split this bug into two bugs (there are two different problems):
- this one is about the crash with hook_modifier on "weechat_print"
- new bug #38350 is about the wrong arguments given to callbacks (list instead of individual arguments).

Sebastien Helleu <flashcode>
Project Administrator
Sat 16 Feb 2013 07:19:02 PM UTC, original submission:  

See attachments for example scripts.

Script "bug-modifier-weechat-print-1.scm"

  This script demonstrates a weechat error when trying to invoke the desired callback with individual parameters.

Script "bug-modifier-weechat-print-2.scm"

  This script demonstrates a crash when trying to invoke weechat:print after setting the modifier callback.

Script "bug-modifier-weechat-print-3.scm"

  This script demonstrates a proper implementation of the weechat_print modifier callback using a single parameter that receives a list of arguments.

Suggested fix:  add note to documentation to indicate that, unlike python or c, guile callbacks use a single parameter to receive a list of four arguments.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #27470:  bug-modifier-weechat-print-1.scm added by None (720B - text/x-scheme)
file #27471:  bug-modifier-weechat-print-2.scm added by None (327B - text/x-scheme)
file #27472:  bug-modifier-weechat-print-3.scm added by None (248B - text/x-scheme)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by flashcode (Updated the item)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-05-20 flashcode Open/ClosedOpen Closed
    2013-02-19 flashcode StatusIn Progress Fixed
    2013-02-19 flashcode SummaryGuile plugin with a weechat:hook_modifier callback for "weechat_print" fails/crashes with improper callback definition. Guile script with a hook_modifier on "weechat_print" crashes WeeChat
    2013-02-18 flashcode StatusNone In Progress
        Assigned toNone flashcode
    2013-02-16 None Attached File- Added bug-modifier-weechat-print-1.scm, #27470
        Attached File- Added bug-modifier-weechat-print-2.scm, #27471
        Attached File- Added bug-modifier-weechat-print-3.scm, #27472

    Back to the top


    Powered by Savane 3.9