buglwIP - A Lightweight TCP/IP stack - Bugs: bug #38701, TCP snd_queuelen inconsistent...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #38701: TCP snd_queuelen inconsistent comments

Submitted by:  Valery Ushakov <uwe>
Submitted on:  Wed 10 Apr 2013 04:23:42 PM UTC  
 
Category: DocumentationSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Wed 24 Apr 2013 07:29:55 PM UTC, comment #2:

Fixed, thanks for reporting.

How did you discover this, anyway?

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Wed 10 Apr 2013 04:55:48 PM UTC, comment #1:

This was, apparently, changed in 2007 by:

http://git.savannah.gnu.org/cgit/lwip.git/commit/src/core/tcp_out.c?id=8be76ed450caeefeefa0a186d15ed8383b43cad7

that changed

in relevant places.

Valery Ushakov <uwe>
Wed 10 Apr 2013 04:23:42 PM UTC, original submission:

The comment for tcp_pcb::snd_queuelen says it's in tcp_segs.

The comment for TCP_SND_QUEUELEN in opt.h says it's in pbufs.

Examining tcp_out.c shows that it is in pbufs - it's adjusted by pbuf_clen(). Though, even there there's a comment at the end of tcp_enqueue_flags() that says "update number of SEGMENTS on the queues".

Valery Ushakov <uwe>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by uwe (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 24 Apr 2013 07:29:55 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1