buglwIP - A Lightweight TCP/IP stack - Bugs: bug #39077, using MEMP_USE_CUSTOM_POOLS...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #39077: using MEMP_USE_CUSTOM_POOLS doesn't work with sizeof

Submitted by:  chrysn <chrysn>
Submitted on:  Mon 27 May 2013 05:32:53 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: Feature RequestStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Wed 11 Feb 2015 10:11:16 PM UTC, comment #1:

Great idea, thanks for the patch.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Mon 27 May 2013 05:32:53 AM UTC, original submission:

when custom lwippools.h files are used, sizeof() often can't be used because #include lines into own libraries (which would declare what is to be sizeof'd) would go in the middle of enum declarations and such.

that can be easily circumvented by including lwip/memp_std.h "blank" once, which causes all external includes to be resolved; when it's later used with LWIP_MEMPOOL defined, the include guards of the external headers get triggered, and nothing problematic gets included.

a patch with explanation is attached.

chrysn <chrysn>

 

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by chrysn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 11 Feb 2015 10:11:16 PM UTCgoldsimonItem GroupNone=>Feature Request
      StatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed
    Mon 27 May 2013 05:32:53 AM UTCchrysnAttached File-=>Added 0001-include-the-memp-struct-list-once-before-actually-us.patch, #28185

    Back to the top


    Powered by Savane 3.1-cleanup1