buglwIP - A Lightweight TCP/IP stack - Bugs: bug #39226, Validity of netif IPv6 address is...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #39226: Validity of netif IPv6 address is not always checked

Submitted by:  Valery Ushakov <uwe>
Submitted on:  Tue 11 Jun 2013 12:27:52 AM UTC  
 
Category: IPv6Severity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Ivan Delamer <idelamer>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Wed 18 Mar 2015 05:57:33 PM UTC, comment #1:

fixed, thanks

Ivan Delamer <idelamer>
Project MemberIn charge of this item.
Tue 11 Jun 2013 12:27:52 AM UTC, original submission:

There are a few places where validity of netif IPv6 address is not checked, usually in a code like this:

Attached patch fixes the few places I found via source code inspection, but while checking this I found some places that do check address validity, but do it with ip6_addr_isvalid(). Appears correct at the first glance, but tentative addresses are not considered ip6_addr_isvalid(), and I think at least in some of those places the tentative addresses are intended to be ok.

Someone with a clue should review that.

My patch goes for conservative !ip6_addr_isinvalid() - just to protect from checking garbage memory.

Valery Ushakov <uwe>

 

Attached Files
file #28289:  valid-ip6-addr.diff added by uwe (3KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by idelamer (Posted a comment)
  • -unavailable- added by goldsimon (Updated the item)
  • -unavailable- added by uwe (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 18 Mar 2015 05:57:33 PM UTCidelamerStatusNone=>Fixed
      Assigned toNone=>idelamer
      Open/ClosedOpen=>Closed
    Fri 28 Jun 2013 08:16:24 PM UTCgoldsimonPlanned Release=>1.5.0
    Tue 11 Jun 2013 12:27:52 AM UTCuweAttached File-=>Added valid-ip6-addr.diff, #28289

    Back to the top


    Powered by Savane 3.1-cleanup1