bugQuilt - Bugs: bug #39833, quilt fold doesn't handle...

 
 

bug #39833: quilt fold doesn't handle whitespace in filenames

Submitted by:  -Deleted Account- <dleonard_leica>
Submitted on:  Wed 21 Aug 2013 04:16:01 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 03 Sep 2013 06:07:04 AM UTC, comment #2:

Applied in the git, thanks.

Martin Quinson <mquinson>
Project Administrator
Mon 26 Aug 2013 02:55:31 PM UTC, comment #1:

Thanks for your report and for the initial patch.

I would prefer however if you could narrow a bit the section for which the IFS is modified. Please check the diff script for inspiration: We have the following chunk before handling file names:

# Properly handle spaces in file names
saved_IFS=$IFS
IFS=$'\n'

And then, once it's done, we have a:

IFS=$saved_IFS

It would be really really cool if you could update your patch to follow this form, please.

Many thanks in advance,
Mt.

Martin Quinson <mquinson>
Project Administrator
Wed 21 Aug 2013 04:16:01 AM UTC, original submission:

Running "quilt fold < some.patch" fails on a patch which contains doxygen-generated files containing whitespace.

Setting IFS to \n fixed it for me (attached patch)

-Deleted Account- <dleonard_leica>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #28982:  fold2.patch added by dleonard_leica (444B - application/octet-stream)
file #28890:  fold-whitespace.patch added by dleonard_leica (281B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mquinson (Posted a comment)
  • -unavailable- added by dleonard_leica (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 03 Sep 2013 06:07:04 AM UTCmquinsonStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Mon 02 Sep 2013 10:00:29 PM UTCdleonard_leicaAttached File-=>Added fold2.patch, #28982
    Wed 21 Aug 2013 04:16:01 AM UTCdleonard_leicaAttached File-=>Added fold-whitespace.patch, #28890

    Back to the top


    Powered by Savane 3.1-cleanup1