bugWeeChat - Bugs: bug #40204, Falsely truncated nicks due to...

 
 

bug #40204: Falsely truncated nicks due to weechat.look.nick_{prefix,suffix}

Submitter:  None
Submitted:  Tue 08 Oct 2013 09:36:34 AM UTC
   
 
Category:  display Severity:  3 - Normal
Priority:  5 - Normal Item Group:  display
Status:  Fixed Privacy:  Public
Assigned to:  flashcode Originator Name: 
Originator Email:  * -email is unavailable- Open/Closed:  Closed
Release:  * 0.4.2 IRC nick:  zralb
* Mandatory Fields

Post a Comment

Add a New Comment Rich Markup
   

Discussion

Sat 19 Oct 2013 02:22:38 PM UTC, comment #2: 

The problem was not on display, but when filters are toggled.
The patch added some display bugs, prefix was shifted by some chars on the right.
So the fix is to compute again the "prefix_max_length" in buffer when filters are toggled.

Sebastien Helleu <flashcode>
Group administrator
Mon 14 Oct 2013 07:24:30 AM UTC, comment #1: 

Attached is a diff that should fix the root if the problem, if I understood all the prefix calculation code correctly.

I believe that 'prefix_length' already contains 'length_nick_prefix_suffix', so there's no need to subtract it again. Subtracting it leads to nickname truncation, as num_spaces will always be < 0.

(file #29372)

Anonymous
Tue 08 Oct 2013 09:36:34 AM UTC, original submission:  

Though weechat.look.prefix_align_max being set to 0, nicks get truncated when weechat.look.nick_prefix or weechat.look.nick_suffix is set to something non empty.

How to reproduce:
/set weechat.look.nick_prefix "<"
and trigger a "redraw", for example by en-/disabling filters (Alt-=).
You should see nicks being truncated though all alignment related options wouldn't trigger this. I don't know another way to trigger the redrawing.

Setting weechat.look.nick_prefix to "" (which is the preset) instantly "untruncates" the nicks.

Anonymous

 

Attached Files

Attached Files

(Note: upload size limit is set to 4.0MiB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Dependencies

This item does not depend on any other items.

No items depend on this one.

 

Mail Notification Carbon-Copy List

Carbon-Copy List
  • -email is unavailable- added by flashcode (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    Votes

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    History

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-02-09 flashcode Open/ClosedOpen Closed
    2013-10-19 flashcode Item GroupNone display
        StatusNone Fixed
        Assigned toNone flashcode
    2013-10-14 None Attached File- Added 0001-Correct-alignment-with-look.nick_-prefix-suffix.patch, #29372

    Back to the top

    Powered by Savane 3.16-ed84.
    Corresponding source code