bugGPSD - Bugs: bug #40331, invalid empty AIS channel ->...

 
 

bug #40331: invalid empty AIS channel -> Warning instead of error

Submitted by:  Marius Kintel <kintel>
Submitted on:  Mon 21 Oct 2013 06:42:44 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 21 Oct 2013 09:48:03 PM UTC, comment #1:

Done and pushed.

Eric S. Raymond <esr>
Project Administrator
Mon 21 Oct 2013 06:42:44 PM UTC, original submission:

Since AIVDO messages don't usually include a channel, I think this case should be reported either as LOG_WARN, or perhaps even LOG_INF, as it's very common. I'm logging one of these every few seconds from an online datasource.

See driver.c:1213:

/*
* Apparently an empty channel is normal for AIVDO sentences,
* which makes sense as they don't come in over radio. This
* is going to break if there's ever an AIVDO type 24, though.
*/
if (strncmp((const char *)field[0], "!AIVDO", 6) != 0)
gpsd_report(session->context->debug, LOG_ERROR,
"invalid empty AIS channel. Assuming 'A'\n");
ais_context = &session->driver.aivdm.context[0];
session->driver.aivdm.ais_channel ='A';

Marius Kintel <kintel>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by esr (Posted a comment)
  • -unavailable- added by kintel (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 22 Nov 2013 01:44:25 PM UTCesrOpen/ClosedOpen=>Closed
    Mon 21 Oct 2013 09:48:03 PM UTCesrStatusNone=>Fixed

    Back to the top


    Powered by Savane 3.1-cleanup1