bugBino - Bugs: bug #40533, [PATCH] Make ist build with stable...

 
 

bug #40533: [PATCH] Make ist build with stable linux distros again

Submitted by:  None
Submitted on:  Sun 10 Nov 2013 01:04:06 AM UTC  
 
Severity: 3 - NormalStatus: Wont Fix
Privacy: PublicAssigned to: Martin Lambers <marlam>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 13 Nov 2014 07:48:56 PM UTC, comment #3:

Qt4 support will remain, in fact it is still the default since Qt5 still occasionally has problems on Linux/X11.

However, Qt5.0 is not supported, it was just too buggy. When using Qt5, you must use >= 5.1.

Martin Lambers <marlam>
Project AdministratorIn charge of this item.
Thu 13 Nov 2014 03:34:08 PM UTC, comment #2:

I don't know about supporting Qt 4.6 (if this patch fixes it, why not apply it), but I wouldn't throw away Qt 4 support!

Qt 5 still misses features that Qt 4 supports fully (e.g. python support), and is still less stable than Qt 4.8 on legacy platforms (linux, OSX, MSWin).

Frédéric Devernay <devernay>
Mon 11 Nov 2013 07:38:27 PM UTC, comment #1:

Sorry, Qt 4.6 is not supported anymore on the master branch. In fact, Qt < 5.1 is on the way out.

Please stick to the 1.4 branch. Version 1.4.3 will be released soon, and it will still support Qt 4.6.

Martin Lambers <marlam>
Project AdministratorIn charge of this item.
Sun 10 Nov 2013 01:04:06 AM UTC, original submission:

libqt4-dev:
Installiert: 4:4.6.3-4+squeeze1
Kandidat: 4:4.6.3-4+squeeze1
Versionstabelle:

      • 4:4.6.3-4+squeeze1 0

990 http://ftp2.de.debian.org/debian/ oldstable/main amd64 Packages
100 /var/lib/dpkg/status

diff --git a/src/main.cpp b/src/main.cpp
index 73295ab..fbb7c63 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -44,6 +44,10 @@
#include <QtGlobal>
#include <QTextCodec>

+#ifdef Q_WS_X11
+# include <X11/Xlib.h>
+#endif
+
#include "gettext.h"
#define _(string) gettext(string)

@@ -200,11 +204,12 @@ int main(int argc, char *argv[])
dbg::init_crashhandler();

/* Initialization: Qt */
- QCoreApplication::setAttribute(Qt::AA_X11InitThreads);
+// QCoreApplication::setAttribute(Qt::AA_X11InitThreads);
#ifdef Q_WS_X11
// This only works with Qt4; Qt5 ignores the 'have_display' flag.
const char *display = getenv("DISPLAY");
bool have_display = (display && display[0] != '\0');
+ if (have_display) XInitThreads();
#else
bool have_display = true;
#endif

FIXME for QT > 4.6.3, the QT_VERSION makro seems not to be used by configure an I've got no Qt5 here, sorry.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by devernay (Posted a comment)
  • -unavailable- added by marlam (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 11 Nov 2013 07:38:27 PM UTCmarlamStatusNone=>Wont Fix
      Assigned toNone=>marlam
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1