bugThe FreeType Project - Bugs: bug #41138, ARM mode broken by "Fix...

 
 

bug #41138: ARM mode broken by "Fix thumb2 inline assembly under LLVM"

Submitted by:  None
Submitted on:  Tue 07 Jan 2014 05:49:30 PM UTC  
 
Severity: 3 - NormalItem Group: Incorrect behaviour
Status: FixedPrivacy: Public
Assigned to: Werner LEMBERG <wl>Open/Closed: Closed
Planned Release: 2.5.3

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 08 Jan 2014 07:54:04 AM UTC, comment #4:

Applied, thanks. I've also fixed the `autofit' problem.

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Wed 08 Jan 2014 07:22:00 AM UTC, comment #3:

Hi Werner,

This simple patch (attached as file #30218: fix_arm_thumb2.patch) should make things work.

BTW, I have tested it with android-ndk, everything works fine now :-)

Chongyu Zhu <lembacon>
Tue 07 Jan 2014 10:22:38 PM UTC, comment #2:

Regarding the error in `autofit': I get this also if I undefine AF_CONFIG_OPTION_CJK and AF_CONFIG_OPTION_INDIC. Already working on a fix.

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Tue 07 Jan 2014 10:14:21 PM UTC, comment #1:

Chong-Yu, can you please have a look and comment?

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Tue 07 Jan 2014 05:49:30 PM UTC, original submission:

I believe that the following patch broke compilation in ARM mode with LLVM:

http://lists.gnu.org/archive/html/freetype-devel/2013-09/msg00028.html

I can build FreeType 2.5.0 for an Android project without any problems, but 2.5.2 gives the following errors:

ftbitmap-129000.s: Assembler messages:
ftbitmap-129000.s:1549: Error: width suffixes are invalid in ARM mode -- `add.w r2,r2,#0x8000'
ftbitmap-129000.s:1561: Error: width suffixes are invalid in ARM mode -- `add.w r1,r1,#0x8000'
ftbitmap-129000.s:1573: Error: width suffixes are invalid in ARM mode -- `add.w r0,r0,#0x8000'
ftbitmap-129000.s:1587: Error: width suffixes are invalid in ARM mode -- `add.w r2,r2,#0x8000'
ftbitmap-129000.s:1604: Error: width suffixes are invalid in ARM mode -- `add.w r1,r1,#0x8000'
ftbitmap-129000.s:1621: Error: width suffixes are invalid in ARM mode -- `add.w r0,r0,#0x8000'
ftbitmap-129000.s:1639: Error: width suffixes are invalid in ARM mode -- `add.w r0,r0,#0x8000'
...

Building in thumb2 mode or undefining _clang_ results in a different set of errors, but these are probably unrelated to the assembly fix and happen with gcc as well:

In file included from jni/../src/autofit/autofit.c:22:
In file included from jni/../src/autofit/afangles.c:20:
In file included from jni/../src/autofit/aftypes.h:42:
jni/../src/autofit/afblue.h:112:19: error: use of undeclared identifier 'af_blue_1_2_1'; did you mean 'af_blue_1_1'?
af_blue_1_2 = af_blue_1_2_1 + 0,
^~~~~~~~~~~~~
af_blue_1_1
jni/../src/autofit/afblue.h:94:5: note: 'af_blue_1_1' declared here
af_blue_1_1 = 213,
^
jni/../src/autofit/afblue.h:171:19: error: use of undeclared identifier 'af_blue_2_2_1'; did you mean 'af_blue_2_1'?
af_blue_2_2 = af_blue_2_2_1 + 0,
^~~~~~~~~~~~~
af_blue_2_1
jni/../src/autofit/afblue.h:160:5: note: 'af_blue_2_1' declared here
af_blue_2_1 = 24,
^
In file included from jni/../src/autofit/autofit.c:32:
jni/../src/autofit/afcjk.c:2295:5: error: use of undeclared identifier 'AF_BLUE_STRINGSET_HANI'
AF_BLUE_STRINGSET_HANI,
^
jni/../src/autofit/aftypes.h:413:5: note: expanded from macro 'AF_DEFINE_SCRIPT_CLASS'
blue_stringset_, \
^
3 errors generated.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #30218:  fix_arm_thumb2.patch added by lembacon (2KiB - application/octet-stream - Hi Werner, this simple patch should make things work. BTW, I have tested it with android-ndk, everything works fine now :-))

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by lembacon (Updated the item)
  • -unavailable- added by wl (Posted a comment)
  • -unavailable- added by wl
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 08 Jan 2014 07:54:04 AM UTCwlStatusNeed Info=>Fixed
      Open/ClosedOpen=>Closed
      Planned ReleaseNone=>2.5.3
    Wed 08 Jan 2014 07:20:17 AM UTClembaconAttached File-=>Added fix_arm_thumb2.patch, #30218
    Tue 07 Jan 2014 10:14:21 PM UTCwlStatusNone=>Need Info
      Assigned toNone=>wl
      Carbon-Copy-=>Added chongyu zhu

    Back to the top


    Powered by Savane 3.1-cleanup1