bugWeeChat - Bugs: bug #41434, Compilation fails on android due...

 
 

bug #41434: Compilation fails on android due <sys/termios.h> being included instead of <termios.h>

Submitted by:  None
Submitted on:  Sun 02 Feb 2014 12:36:42 PM UTC  
 
Category: compilationSeverity: 3 - Normal
Item Group: compile/installStatus: Fixed
Privacy: PublicAssigned to: Sebastien Helleu <flashcode>
Originator Name: Fredrik FornwallOriginator Email: -unavailable-
Open/Closed: ClosedRelease: 0.4.2
IRC nick: fornwall

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 02 Feb 2014 02:15:17 PM UTC, comment #1:

Thanks, committed.

So I did that:
- I removed the include for Cygwin: I tested and it looks like the include is not needed at all
- the include in gui-curses-window.c was added for Solaris, but I don't have any way to test on this OS, so I replaced the include here (your patch), in the hope it is still OK on Solaris.

I tested on GNU/Hurd and OpenBSD, no problem with the patch.

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Sun 02 Feb 2014 12:36:42 PM UTC, original submission:

Android does not have <sys/termios.h> but <termios.h>.

I believe that <termios.h> is the portable and standard file to include anyway:

The attached patch does the sys/termios.h => termios.h replacement.

The change in gui-curses.h is not strictly required since it's guarded by ifdef _CYGWIN_, but we might as well do the change there for consistency.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #30434:  termios_h_include_path.patch added by None (840B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by flashcode (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 09 Feb 2014 09:39:16 AM UTCflashcodeOpen/ClosedOpen=>Closed
    Sun 02 Feb 2014 02:15:17 PM UTCflashcodeAssigned toNone=>flashcode
      Release2.1-dev=>0.4.2
    Sun 02 Feb 2014 02:15:16 PM UTCflashcodeCategoryNone=>compilation
      Item GroupNone=>compile/install
      StatusNone=>Fixed
    Sun 02 Feb 2014 12:37:55 PM UTCNoneAttached File-=>Added termios_h_include_path.patch, #30434

    Back to the top


    Powered by Savane 3.1-cleanup1