bugWeeChat - Bugs: bug #41434, Compilation fails on android due...

 
 

bug #41434: Compilation fails on android due <sys/termios.h> being included instead of <termios.h>

Submitted by:  None
Submitted on:  Sun 02 Feb 2014 12:36:42 PM UTC  
 
Category:  compilation Severity:  3 - Normal
Item Group:  compile/install Status:  Fixed
Privacy:  Public Assigned to:  Sebastien Helleu <flashcode>
Originator Name:  Fredrik Fornwall Originator Email:  -email is unavailable-
Open/Closed:  Closed Release:  0.4.2
IRC nick:  fornwall

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 02 Feb 2014 02:15:17 PM UTC, comment #1:

Thanks, committed.

So I did that:
- I removed the include for Cygwin: I tested and it looks like the include is not needed at all
- the include in gui-curses-window.c was added for Solaris, but I don't have any way to test on this OS, so I replaced the include here (your patch), in the hope it is still OK on Solaris.

I tested on GNU/Hurd and OpenBSD, no problem with the patch.

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Sun 02 Feb 2014 12:36:42 PM UTC, original submission:

Android does not have <sys/termios.h> but <termios.h>.

I believe that <termios.h> is the portable and standard file to include anyway:

The attached patch does the sys/termios.h => termios.h replacement.

The change in gui-curses.h is not strictly required since it's guarded by ifdef _CYGWIN_, but we might as well do the change there for consistency.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #30434:  termios_h_include_path.patch added by None (840B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by flashcode (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-02-09 flashcode Open/ClosedOpen => Closed
    2014-02-02 flashcode Assigned toNone => flashcode
        Release2.4-dev => 0.4.2
    2014-02-02 flashcode CategoryNone => compilation
        Item GroupNone => compile/install
        StatusNone => Fixed
    2014-02-02 None Attached File- => Added termios_h_include_path.patch, #30434

    Back to the top


    Powered by Savane 3.4