buglwIP - A Lightweight TCP/IP stack - Bugs: bug #41686, ipv4 ip_reass() crash error

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #41686: ipv4 ip_reass() crash error

Submitted by:  hanhui <hanhui03>
Submitted on:  Tue 25 Feb 2014 11:02:38 AM UTC  
 
Category: IPv4Severity: 3 - Normal
Item Group: Crash ErrorStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Mon 19 May 2014 08:08:13 PM UTC, comment #3:

Fixed, thanks for reporting.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Sat 17 May 2014 11:49:32 AM UTC, comment #2:

I mentioned this problem in https://savannah.nongnu.org/bugs/?41041#comment4 - it's a regression introduced by the fix to that bug.

The loop should actually end with ipr_prev = ipr->next :)

Valery Ushakov <uwe>
Fri 16 May 2014 08:02:12 PM UTC, comment #1:

Are you sure the patch below is complete? I would have thought the 'for' line should end with

ipr_prev = ipr_prev->next

not

ipr = ipr->next

to prevent having an endless loop?

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Tue 25 Feb 2014 11:02:38 AM UTC, original submission:

ip_reass()
{
...;
/* find the previous entry in the linked list */
for (ipr_prev = reassdatagrams_ipv4; ipr_prev != NULL; ipr = ipr->next) {
if (ipr_prev->next == ipr) {
break;
}
}

should be:

/* find the previous entry in the linked list */
if (ipr == reassdatagrams_ipv4) {
ipr_prev = NULL;
} else {
for (ipr_prev = reassdatagrams_ipv4; ipr_prev != NULL; ipr = ipr->next) {
if (ipr_prev->next == ipr) {
break;
}
}
}
}

Han.hui

hanhui <hanhui03>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by uwe (Posted a comment)
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by hanhui03 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 19 May 2014 08:08:13 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1