bugGPSD - Bugs: bug #42184, Crash when client disconnects

 
 

bug #42184: Crash when client disconnects

Submitted by:  None
Submitted on:  Thu 24 Apr 2014 01:28:22 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Eric S. Raymond <esr>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 24 Apr 2014 01:28:22 PM UTC, original submission:

I observed GPSD crash when a client disconnects.

The access to subscriber_t->fd is not synchronized between the main loop and the ppsthread. So the ppsthread may call asynchronously detach_client() via ship_pps_drift_message()/notify_watchers()/throttled_write().

The attached patch tries to avoid that race condition.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #31241:  gps-client-detach.patch added by None (3KiB - text/x-patch)
file #31242:  gspd-backtrace.txt added by None (391B - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by esr (Updated the item)
  • -unavailable- added by weo
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 23 Aug 2014 05:46:51 PM UTCesrOpen/ClosedOpen=>Closed
    Sat 17 May 2014 12:39:51 PM UTCesrStatusNone=>Fixed
      Assigned toNone=>esr
    Thu 24 Apr 2014 01:50:43 PM UTCweoCarbon-Copy-=>Added weo
    Thu 24 Apr 2014 01:28:22 PM UTCNoneAttached File-=>Added gps-client-detach.patch, #31241
      Attached File-=>Added gspd-backtrace.txt, #31242

    Back to the top


    Powered by Savane 3.1-cleanup1