bugThe FreeType Project - Bugs: bug #42788, iOS Builds broken in commit c0a6f20

 
 

bug #42788: iOS Builds broken in commit c0a6f20

Submitted by:  David Wimsey <dwimsey>
Submitted on:  Thu 17 Jul 2014 06:44:59 AM UTC  
 
Severity: 3 - NormalItem Group: None
Status: FixedPrivacy: Public
Assigned to: Alexei Podtelezhnikov <podtelez>Open/Closed: Closed
Planned Release: 2.5.4

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 17 Jul 2014 08:35:43 AM UTC, comment #3:

Never mind, I've just done it :-)

Thanks for the report.

Werner LEMBERG <wl>
Project Administrator
Thu 17 Jul 2014 08:16:15 AM UTC, comment #2:

Alexei, please take care of this!

Werner LEMBERG <wl>
Project Administrator
Thu 17 Jul 2014 07:27:10 AM UTC, comment #1:

The following changes since commit c0a6f20a4b33fefce50dafbf0d7f20aec6b0e724:

Replace `ft_highpow2' function. (2014-07-16 22:05:56 -0400)

are available in the git repository at:

https://github.com/dwimsey/freetype2.git hotfix/FT_MSB-c0a6f20

for you to fetch changes up to a7620c5b462dcc24b2916516ff9336de64362bab:

Included ftcalc.h as required to make FT_MSB available for use in pfrobjs.c (2014-07-17 03:18:46 -0400)

----------------------------------------------------------------
David Wimsey (1):
Included ftcalc.h as required to make FT_MSB available for use in pfrobjs.c

src/pfr/pfrtypes.h | 1 +
1 file changed, 1 insertion(+)

David Wimsey <dwimsey>
Thu 17 Jul 2014 06:44:59 AM UTC, original submission:

It appears that the move to FT_MSB from ft_highpow2 in commit c0a6f20 breaks iOS builds.

The problem appears to be because FT_MSB isn't defined, or rather include/internal/ftcalc.h isn't included in src/pfr/pfrobjs.c when building for iOS.

To recreate, put the attached iOS.cmake in the directory you run cmake from and run (from OSX of course):

cmake -GXcode -DIOS_PLATFORM=OS -DCMAKE_TOOLCHAIN_FILE=iOS.cmake .
xcodebuild -target freetype -config Debug

In the attached build log, the error shows itself on line 1396

The prior commit (177982e) builds fine.

David Wimsey <dwimsey>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #31731:  iOS.cmake added by dwimsey (8KiB - application/octet-stream)
file #31732:  freetype-build.txt added by dwimsey (499KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by wl (Posted a comment)
  • -unavailable- added by dwimsey (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 17 Jul 2014 08:35:43 AM UTCwlStatusNone=>Fixed
      Open/ClosedOpen=>Closed
      Planned ReleaseNone=>2.5.4
    Thu 17 Jul 2014 08:16:15 AM UTCwlAssigned toNone=>podtelez
    Thu 17 Jul 2014 06:44:59 AM UTCdwimseyAttached File-=>Added iOS.cmake, #31731
      Attached File-=>Added freetype-build.txt, #31732

    Back to the top


    Powered by Savane 3.1-cleanup1