bugGPSD - Bugs: bug #43129, ntpshm patch is incomplete

 
 

bug #43129: ntpshm patch is incomplete

Submitted by:  Vicente Olivert Riera <vriera>
Submitted on:  Tue 02 Sep 2014 09:35:28 AM UTC  
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  Eric S. Raymond <esr>
Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 02 Sep 2014 09:35:28 AM UTC, original submission:  

http://git.savannah.gnu.org/cgit/gpsd.git/commit/?id=80cd103396fcd1185a476761bfb267ce12f64b32

The above patch is incomplete. If you enable the ntpshm_latch function only when NTPSHM_ENABLE is defined, then you should do the same for the calls to that function. Otherwise it will fail like this:

/home/chroot/media/code/buildroot/autobuilder/instance-0/output/host/usr/bin/mipsel-linux-gcc -o gpsmon -pthread --sysroot=/home/chroot/media/code/buildroot/autobuilder/instance-0/output/host/usr/mipsel-buildroot-linux-uclibc/sysroot gpsmon.o monitor_italk.o monitor_nmea.o monitor_oncore.o monitor_sirf.o monitor_superstar2.o monitor_tnt.o monitor_ubx.o monitor_garmin.o -L. -L/home/chroot/media/code/buildroot/autobuilder/instance-0/output/host/usr/mipsel-buildroot-linux-uclibc/sysroot/usr/lib -lrt -lbluetooth -lgpsd -lusb-1.0 -lbluetooth -lgps -lncurses -lm
gpsmon.o: In function `gpsmon_hook':
gpsmon.c:(.text+0xa54): undefined reference to `ntpshm_latch'
gpsmon.c:(.text+0xa5c): undefined reference to `ntpshm_latch'
collect2: error: ld returned 1 exit status

Full build log:
http://autobuild.buildroot.net/results/fa2/fa2b71c087339ff7a0837e34f35abf80dbb349b6/build-end.log

Vicente Olivert Riera <vriera>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by esr (Updated the item)
  • -email is unavailable- added by vriera (Submitted the item)
  • -email is unavailable- added by vriera
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-02-22 esr Open/ClosedOpen => Closed
    2014-09-04 esr StatusNone => Fixed
        Assigned toNone => esr
    2014-09-02 vriera Carbon-Copy- => Added spdawson@gmail.com

    Back to the top


    Powered by Savane 3.6