bugGoatee - Bugs: bug #43149, Reconsider the failure case of...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #43149: Reconsider the failure case of Monad.goUp, goDown.

Submitted by:  Bryan Gardiner <khumba>
Submitted on:  Fri 05 Sep 2014 06:15:49 AM UTC  
 
Category: LibrarySeverity: 4 - Important
Item Group: FeatureStatus: Fixed
Privacy: PublicAssigned to: Bryan Gardiner <khumba>
Open/Closed: ClosedRelease: None
Fixed Release: 0.3.0

Thu 15 Jan 2015 01:18:52 AM UTC, comment #1:

Made the navigation functions return booleans, and removed the redundant navigation functions from UiCtrl[1]. Also turned on warnings for not checking result codes in do blocks[2]. In [1] I mostly checked the result explicitly in non-test code and used 'fail' on failure, but did just pattern match with "True <- ..." a couple times. These cases are all internal errors if they occur, and GHC gives line numbers for do pattern match failures, so even just pattern matching is easily traceable.

[1] http://git.savannah.gnu.org/cgit/goatee.git/commit/?id=79dc4a34242c0209a4bd2a4f1aed256448feb07f

[2] http://git.savannah.gnu.org/cgit/goatee.git/commit/?id=10a98dd6fa5aa0e9047c8f4cbb3f416d6ead543f

Bryan Gardiner <khumba>
Project AdministratorIn charge of this item.
Fri 05 Sep 2014 06:15:49 AM UTC, original submission:

Calling 'fail' in case a move can't be made is a bit drastic. Might be worth returning a Bool or indicating failure some other way instead.

Bryan Gardiner <khumba>
Project AdministratorIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by khumba (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 20 Mar 2015 05:16:13 AM UTCkhumbaOpen/ClosedOpen=>Closed
      Fixed ReleaseNone=>0.3.0
    Thu 15 Jan 2015 01:18:52 AM UTCkhumbaStatusNone=>Fixed
    Fri 09 Jan 2015 01:43:37 AM UTCkhumbaSeverity3 - Normal=>4 - Important

    Back to the top


    Powered by Savane 3.1-cleanup1