bugpyFormex - Bugs: bug #43339, Geometry._set_coords_inplace...

 
 

bug #43339: Geometry._set_coords_inplace raises error with somme coords methods

Submitted by:  francesco <francio>
Submitted on:  Wed 01 Oct 2014 09:18:19 AM UTC  
 
Category: CoreSeverity: 3 - Normal
Item Group: Functionality errorStatus: Fixed
Privacy: PublicAssigned to: Benedict Verhegghe <bverheg>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 01 Oct 2014 03:35:28 PM UTC, comment #2:

This is fixed in 947d8e3.

Benedict Verhegghe <bverheg>
Project AdministratorIn charge of this item.
Wed 01 Oct 2014 03:08:45 PM UTC, comment #1:

The error occurs in then spherical() transformation, which however works fine in a Formex and Mesh. An obvious workaround thus goes over a transformation to Formex (and back if needed).

Formex and Mesh have their own implementation of set_coords, forcing the argument to be Coords, while Curve and its subclasses like PolyLine, inherit it from Geometry. We should fix it there.

I decreased the severity because there is a workaround (now).

Benedict Verhegghe <bverheg>
Project AdministratorIn charge of this item.
Wed 01 Oct 2014 09:18:19 AM UTC, original submission:

some coords methods return a numpy array instead of Coords and the check of the Coords type in _set_coords_inplace fails.

I am not sure at which level should be fixed or the best (read Benedict ) way to do it
try.

fails with error

File "/home/Francesco/pyformex/pyformex/geometry.py", line 155, in newf
return self._set_coords(coords_func(self.coords,args,*kargs))
File "/home/Francesco/pyformex/pyformex/geometry.py", line 179, in _set_coords_copy
return self.copy()._set_coords_inplace(coords)
File "/home/Francesco/pyformex/pyformex/geometry.py", line 172, in _set_coords_inplace
raise ValueError("Invalid reinitialization of Geometry coords")
ValueError: Invalid reinitialization of Geometry coords

francesco <francio>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bverheg (Posted a comment)
  • -unavailable- added by francio (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 01 Oct 2014 03:35:28 PM UTCbverhegStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Wed 01 Oct 2014 03:08:45 PM UTCbverhegSeverity4 - Important=>3 - Normal

    Back to the top


    Powered by Savane 3.1-cleanup1