buglwIP - A Lightweight TCP/IP stack - Bugs: bug #43514, SMTP authentication disabled when...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #43514: SMTP authentication disabled when only LOGIN is enabled

Submitted by:  Uli Köhler <ulikoehler>
Submitted on:  Sat 01 Nov 2014 11:48:58 PM UTC  
 
Category: ContribSeverity: 3 - Normal
Item Group: Faulty BehaviourStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: 1.4.1

Sun 02 Nov 2014 07:15:50 PM UTC, comment #1:

Fixed, thanks for reporting.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Sat 01 Nov 2014 11:48:58 PM UTC, original submission:

In lwip-contrib/apps/smtp/smtp.c (verified in git head and STABLE-1_4_1), several code blocks including smtp_prepare_auth_or_mail() are enabled/disabled using the following macro:

#if SMTP_SUPPORT_AUTH_AUTH || SMTP_SUPPORT_AUTH_LOGIN

I believe this is a typo and it should read:

#if SMTP_SUPPORT_AUTH_PLAIN || SMTP_SUPPORT_AUTH_LOGIN

because SMTP_SUPPORT_AUTH_AUTH is defined nowhere and it clearly makes sense to enable the code blocks if any of the both auth methods are enabled.

I'm trying to run the SMTP client with LOGIN auth disabled and my mailserver shows that no authentication attempt is performed.

Suggested fix:

Replace all occurences of "SMTP_SUPPORT_AUTH_AUTH" with "SMTP_SUPPORT_AUTH_PLAIN" in smtp.c.

Uli Köhler <ulikoehler>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by ulikoehler (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 02 Nov 2014 07:15:50 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1