buglwIP - A Lightweight TCP/IP stack - Bugs: bug #43583, dhcp_recv() won't work on netifs...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #43583: dhcp_recv() won't work on netifs with multiple hwaddrs

Submitted by:  Hugo Fiennes <hugof>
Submitted on:  Wed 12 Nov 2014 01:29:05 AM UTC  
 
Category: DHCPSeverity: 3 - Normal
Item Group: Faulty BehaviourStatus: Invalid
Privacy: PublicAssigned to: None
Open/Closed: ClosedPlanned Release: None
lwIP version: 1.4.1

Wed 12 Nov 2014 09:28:00 AM UTC, comment #2:

AFAIK, we don't support netif with multiple hwaddr addresses (does that actually exist !?)

Sylvain Rochet <gradator>
Project Member
Wed 12 Nov 2014 01:44:42 AM UTC, comment #1:

I need more sleep. Please delete this.

Hugo Fiennes <hugof>
Wed 12 Nov 2014 01:29:05 AM UTC, original submission:

...as the code will abort receive packet processing on the first mismatch, whereas it should only abort if the chaddr is not ANY of the netif hwaddrs.

See below from dhcp_recv():

/* iterate through hardware address and match against DHCP message */
for (i = 0; i < netif->hwaddr_len; i++) {
if (netif->hwaddr[i] != reply_msg->chaddr[i]) {
LWIP_DEBUGF(DHCP_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_LEVEL_WARNING,
("netif->hwaddr[%"U16_F"]==%02"X16_F" != reply_msg->chaddr[%"U16_F"]==%02"X16_F"\n",
(u16_t)i, (u16_t)netif->hwaddr[i], (u16_t)i, (u16_t)reply_msg->chaddr[i]));
goto free_pbuf_and_return;
}
}

Hugo Fiennes <hugof>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gradator (Posted a comment)
  • -unavailable- added by hugof (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 12 Nov 2014 09:28:00 AM UTCgradatorStatusNone=>Invalid
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1