buglwIP - A Lightweight TCP/IP stack - Bugs: bug #43904, ip_route() and ip6_route() must...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #43904: ip_route() and ip6_route() must detect linkup status.

Submitted by:  hanhui <hanhui03>
Submitted on:  Tue 30 Dec 2014 05:42:25 AM UTC  
 
Category: IPv4Severity: 3 - Normal
Item Group: Faulty BehaviourStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Wed 18 Mar 2015 07:26:02 PM UTC, comment #5:

OK. In that case, I'd leave it as it is now.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Wed 18 Mar 2015 05:35:55 PM UTC, comment #4:

I don't think so. In general that case should never trigger. For link-local we should always have a source address. This is either done by the user, or the stack chooses one using ip6_select_source_address() on a given netif.

Probably we should even eliminate that case and return ERR_RTE.

Ivan Delamer <idelamer>
Project Member
Wed 18 Mar 2015 05:09:32 PM UTC, comment #3:

From reading the diff, it looks like link-local packets where the source address is ANY would be dropped when the default netif is down. I'm not saying this is wrong, but would it make sense to send them to any other netif instead?

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Wed 18 Mar 2015 04:56:32 PM UTC, comment #2:

fixed ip6 part.

Ivan Delamer <idelamer>
Project Member
Mon 09 Mar 2015 08:36:39 PM UTC, comment #1:

Fixed the IPv4 part.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Tue 30 Dec 2014 05:42:25 AM UTC, original submission:

Hi Simon

ip_route() select netif only detect netif_is_up(), I suggest that add netif_is_link_up() detect.

ip6_route() did not even detect the state of the network interface.

Han.hui

hanhui <hanhui03>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by idelamer (Posted a comment)
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by hanhui03 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 18 Mar 2015 04:56:32 PM UTCidelamerStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Mon 09 Mar 2015 08:36:39 PM UTCgoldsimonStatusNone=>In Progress
      Assigned toNone=>goldsimon

    Back to the top


    Powered by Savane 3.1-cleanup1