bugGPSD - Bugs: bug #43949, assert() calls with side effects

 
 

bug #43949: assert() calls with side effects

Submitted by:  Zbigniew Chyla <zchyla_nokia>
Submitted on:  Wed 07 Jan 2015 03:41:13 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Eric S. Raymond <esr>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 07 Jan 2015 03:41:13 PM UTC, original submission:

I've found two assert() calls with arguments that contain expressions with side effects. These side effects are file/socket reads/writes.

The first one is "assert(fwrite(…))" inside "gpsmon_hook" (gpsmon.c).
The second one is "assert(funcall != -23)" inside "ignore_return" macro (gpsd.h-tail), which is used with "read(…)" and "write(…)" as arguments.

Zbigniew Chyla <zchyla_nokia>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #32780:  0001-Move-side-effects-out-of-assert.patch added by zchyla_nokia (1KiB - text/x-patch - [PATCH] Move side effects out of assert())

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by esr (Updated the item)
  • -unavailable- added by zchyla_nokia (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 22 Feb 2015 05:03:44 PM UTCesrOpen/ClosedOpen=>Closed
    Thu 08 Jan 2015 03:33:33 AM UTCesrStatusNone=>Fixed
      Assigned toNone=>esr
    Wed 07 Jan 2015 03:43:35 PM UTCzchyla_nokiaAttached File-=>Added 0001-Move-side-effects-out-of-assert.patch, #32780

    Back to the top


    Powered by Savane 3.1-cleanup1