bugGPSD - Bugs: bug #44267, Unused return values of...

 
 

bug #44267: Unused return values of nmea_send() and snarfline()

Submitted by:  Zbigniew Chyla <zchyla_nokia>
Submitted on:  Mon 16 Feb 2015 01:16:26 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Wont Fix
Privacy: PublicAssigned to: Eric S. Raymond <esr>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 16 Feb 2015 03:01:19 AM UTC, comment #1:

The return value is intended for uniformity with other driver-level write functions, and might become useful in the future.

Your attention to such details is appreciated, however; please keep auditing the code for what you think are bad smells. I am, as you have seen, generally willing to accept that kind of patch.

Eric S. Raymond <esr>
Project AdministratorIn charge of this item.
Mon 16 Feb 2015 01:16:26 AM UTC, original submission:

Both nmea_send() and snarfline() return values that are never used. All callers ignore them and use casts to void to make code checkers happy. It decreases code readability, so I suggest removing unused return values. See attached patches for details.

Zbigniew Chyla <zchyla_nokia>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by esr (Posted a comment)
  • -unavailable- added by zchyla_nokia (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 13 Mar 2015 01:39:44 PM UTCesrOpen/ClosedOpen=>Closed
    Mon 16 Feb 2015 03:01:19 AM UTCesrStatusNone=>Wont Fix
      Assigned toNone=>esr
    Mon 16 Feb 2015 01:16:26 AM UTCzchyla_nokiaAttached File-=>Added 0001-Remove-unused-return-value-from-nmea_send.patch, #33095
      Attached File-=>Added 0002-Remove-unused-return-value-from-snarfline.patch, #33096

    Back to the top


    Powered by Savane 3.1-cleanup1