bugBino - Bugs: bug #44576, Changed behaviour of str::replace...

 
 

bug #44576: Changed behaviour of str::replace causing video playback to fail

Submitted by:  None
Submitted on:  Thu 19 Mar 2015 02:40:10 AM UTC  
 
Severity: 3 - NormalStatus: Fixed
Privacy: PublicAssigned to: Martin Lambers <marlam>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 19 Mar 2015 05:42:33 AM UTC, comment #1:

Thank you very much for spotting this. The problem is now fixed.

Martin Lambers <marlam>
Project AdministratorIn charge of this item.
Thu 19 Mar 2015 02:40:10 AM UTC, original submission:

In this commit: http://git.savannah.gnu.org/cgit/bino.git/commit/?id=3d2a4dab0402cc3e0f77f4d7d83cf3650fc333d1

str::replace has changed from an in-place replacement to returning a string with replacements made. This causes use of str::replace to do nothing, since the returned string is not reassigned to the original string. This then causes video playback to fail, since settings are not replaced in shader files.

affected files:
src/subtitle_renderer.cpp
src/video_output.cpp

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by marlam (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 19 Mar 2015 05:42:33 AM UTCmarlamStatusNone=>Fixed
      Assigned toNone=>marlam
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1