bugGPSD - Bugs: bug #44921, Unnecessary memcpy() calls for...

 
 

bug #44921: Unnecessary memcpy() calls for copying structs

Submitted by:  Zbigniew Chyla <zchyla_nokia>
Submitted on:  Fri 24 Apr 2015 04:41:36 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Eric S. Raymond <esr>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 24 Apr 2015 04:41:36 PM UTC, original submission:

When preparing a fix for #44919, I noticed that there're many other ocurrences of copying structs using memcpy() instead of simple assignment, which is more concise and type-safe.

The attached patch replaces memcpy() calls with assignments.

Zbigniew Chyla <zchyla_nokia>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by esr (Updated the item)
  • -unavailable- added by zchyla_nokia (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 03 Jun 2015 02:12:56 PM UTCesrOpen/ClosedOpen=>Closed
    Tue 28 Apr 2015 12:27:08 PM UTCesrStatusNone=>Fixed
      Assigned toNone=>esr
    Fri 24 Apr 2015 04:41:36 PM UTCzchyla_nokiaAttached File-=>Added 0001-Copy-structs-using-assignment-not-memcpy.patch, #33774

    Back to the top


    Powered by Savane 3.1-cleanup1