buglwIP - A Lightweight TCP/IP stack - Bugs: bug #45022, Missing declaration for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #45022: Missing declaration for FD_SET_VAL()

Submitted by:  Edgar Bonet <ebonet>
Submitted on:  Tue 05 May 2015 12:01:45 PM UTC  
 
Category: sockets/netconnSeverity: 3 - Normal
Item Group: Compiler WarningStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Tue 05 May 2015 12:11:39 PM UTC, comment #1:

Perfect, applied, thank you Edgar.

Sylvain Rochet <gradator>
Project Member
Tue 05 May 2015 12:01:45 PM UTC, original submission:

Compiling simhost, from the Unix port, fails with the following
(slightly edited) error message:

lwip/src/api/sockets.c:1159:7: In function ‘lwip_selscan’:
error: implicit declaration of function ‘FD_SET_VAL’

FD_SET_VAL is a macro normally defined in
lwip/src/include/lwip/sockets.h, but its definition is conditioned
roughly as follows:

#ifndef FD_SET
# define FD_SET(n, p) ...
# define FD_SET_VAL(n, p) ...
...
#endif

which carries the assumption that defined(FD_SET) implies
defined(FD_SET_VAL). However, on the Unix port, FD_SET() is defined by
system headers (included via lwip/src/include/lwip/arch.h and
lwip-contrib/ports/unix/include/arch/cc.h), but FD_SET_VAL(), which
appears to be non-standard, is not.

The attached patch fixes this issue by providing an alternative
definition of FD_SET_VAL() when defined(FD_SET) && !defined(FD_SET_VAL).

Edgar Bonet <ebonet>

 

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gradator (Posted a comment)
  • -unavailable- added by ebonet (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 05 May 2015 12:11:39 PM UTCgradatorStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Tue 05 May 2015 12:01:45 PM UTCebonetAttached File-=>Added 0001-In-lwip-sockets.h-do-not-assume-defined-FD_SET-impli.patch, #33920

    Back to the top


    Powered by Savane 3.1-cleanup1